Closed Bug 1622969 Opened 4 years ago Closed 3 years ago

Intermittent SUMMARY: ThreadSanitizer: data race /builds/worker/checkouts/gecko/js/src/vm/Shape.h:863:10 in baseUnowned

Categories

(Core :: JavaScript: GC, defect, P5)

Product:
Core
Component:
JavaScript: GC
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox76 --- affected

People

(Reporter: intermittent-bug-filer, Assigned: jonco)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell needswork])

Attachments

(1 file)

Bug 1622969 - Improve assertions about when compacting GC can update pointers on background threads r?sfink
47 bytes, text/x-phabricator-request
Details | Review

Filed by: malexandru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=293409870&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/UdE8W6gEQeGLnSNPT7stTg/runs/1/artifacts/public/logs/live_backing.log

[task 2020-03-16T22:39:49.244Z] 22:39:49     INFO - TEST-START | layout/style/test/test_initial_storage.html
[task 2020-03-16T22:39:54.624Z] 22:39:54     INFO - GECKO(1177) | MEMORY STAT | vsize 130550681MB | residentFast 1340MB
[task 2020-03-16T22:39:55.028Z] 22:39:55     INFO - TEST-OK | layout/style/test/test_initial_storage.html | took 5779ms
[task 2020-03-16T22:39:55.390Z] 22:39:55     INFO - GECKO(1177) | ==================
[task 2020-03-16T22:39:55.390Z] 22:39:55     INFO - GECKO(1177) | WARNING: ThreadSanitizer: data race (pid=1300)
[task 2020-03-16T22:39:55.390Z] 22:39:55     INFO - GECKO(1177) |   Read of size 8 at 0x7f1ee2968350 by main thread:
[task 2020-03-16T22:39:55.390Z] 22:39:55     INFO - GECKO(1177) |     #0 baseUnowned /builds/worker/checkouts/gecko/js/src/vm/Shape.h:863:10 (libxul.so+0x682cfd3)
[task 2020-03-16T22:39:55.390Z] 22:39:55     INFO - GECKO(1177) |     #1 unowned /builds/worker/checkouts/gecko/js/src/vm/Shape.h:853:22 (libxul.so+0x682cfd3)
[task 2020-03-16T22:39:55.390Z] 22:39:55     INFO - GECKO(1177) |     #2 js::Shape::fixupShapeTreeAfterMovingGC() /builds/worker/checkouts/gecko/js/src/vm/Shape.cpp:1968:39 (libxul.so+0x682cfd3)
[task 2020-03-16T22:39:55.391Z] 22:39:55     INFO - GECKO(1177) |     #3 js::Shape::fixupAfterMovingGC() /builds/worker/checkouts/gecko/js/src/vm/Shape.cpp:1994:5 (libxul.so+0x682d407)
[task 2020-03-16T22:39:55.391Z] 22:39:55     INFO - GECKO(1177) |     #4 UpdateCellPointers<js::Shape> /builds/worker/checkouts/gecko/js/src/gc/GC.cpp:2175:9 (libxul.so+0x6c1ab1a)
[task 2020-03-16T22:39:55.391Z] 22:39:55     INFO - GECKO(1177) |     #5 UpdateArenaPointersTyped<js::Shape> /builds/worker/checkouts/gecko/js/src/gc/GC.cpp:2182:5 (libxul.so+0x6c1ab1a)
[task 2020-03-16T22:39:55.391Z] 22:39:55     INFO - GECKO(1177) |     #6 UpdateArenaPointers /builds/worker/checkouts/gecko/js/src/gc/GC.cpp:2198:5 (libxul.so+0x6c1ab1a)
[task 2020-03-16T22:39:55.392Z] 22:39:55     INFO - GECKO(1177) |     #7 UpdateArenaListSegmentPointers(js::gc::GCRuntime*, ArenaListSegment const&) /builds/worker/checkouts/gecko/js/src/gc/GC.cpp:2222:5 (libxul.so+0x6c1ab1a)
[task 2020-03-16T22:39:55.392Z] 22:39:55     INFO - GECKO(1177) |     #8 js::gc::ParallelWorker<ArenaListSegment, ArenasToUpdate>::run() /builds/worker/checkouts/gecko/js/src/gc/ParallelWork.h:52:22 (libxul.so+0x6c4c1b4)
[task 2020-03-16T22:39:55.392Z] 22:39:55     INFO - GECKO(1177) |     #9 js::GCParallelTask::runTask() /builds/worker/checkouts/gecko/js/src/gc/GCParallelTask.cpp:143:3 (libxul.so+0x6c401ff)
[task 2020-03-16T22:39:55.393Z] 22:39:55     INFO - GECKO(1177) |     #10 runFromMainThread /builds/worker/checkouts/gecko/js/src/gc/GCParallelTask.cpp:117:3 (libxul.so+0x6c193f1)
[task 2020-03-16T22:39:55.393Z] 22:39:55     INFO - GECKO(1177) |     #11 js::gc::GCRuntime::updateCellPointers(JS::Zone*, mozilla::EnumSet<js::gc::AllocKind, unsigned long>, unsigned long) /builds/worker/checkouts/gecko/js/src/gc/GC.cpp:2387:12 (libxul.so+0x6c193f1)
[task 2020-03-16T22:39:55.394Z] 22:39:55     INFO - GECKO(1177) |     #12 updateAllCellPointers /builds/worker/checkouts/gecko/js/src/gc/GC.cpp:2450:3 (libxul.so+0x6c1b55f)
[task 2020-03-16T22:39:55.394Z] 22:39:55     INFO - GECKO(1177) |     #13 js::gc::GCRuntime::updateZonePointersToRelocatedCells(JS::Zone*) /builds/worker/checkouts/gecko/js/src/gc/GC.cpp:2489:3 (libxul.so+0x6c1b55f)
[task 2020-03-16T22:39:55.395Z] 22:39:55     INFO - GECKO(1177) |     #14 js::gc::GCRuntime::compactPhase(JS::GCReason, js::SliceBudget&, js::gc::AutoGCSession&) /builds/worker/checkouts/gecko/js/src/gc/GC.cpp:6158:7 (libxul.so+0x6c33b02)
[task 2020-03-16T22:39:55.395Z] 22:39:55     INFO - GECKO(1177) |     #15 js::gc::GCRuntime::incrementalSlice(js::SliceBudget&, mozilla::Maybe<JSGCInvocationKind> const&, JS::GCReason, js::gc::AutoGCSession&) /builds/worker/checkouts/gecko/js/src/gc/GC.cpp:6605:13 (libxul.so+0x6c35a1a)
[task 2020-03-16T22:39:55.395Z] 22:39:55     INFO - GECKO(1177) |     #16 js::gc::GCRuntime::gcCycle(bool, js::SliceBudget, mozilla::Maybe<JSGCInvocationKind> const&, JS::GCReason) /builds/worker/checkouts/gecko/js/src/gc/GC.cpp:6968:3 (libxul.so+0x6c37349)
[task 2020-03-16T22:39:55.398Z] 22:39:55     INFO - GECKO(1177) |     #17 js::gc::GCRuntime::collect(bool, js::SliceBudget, mozilla::Maybe<JSGCInvocationKind> const&, JS::GCReason) /builds/worker/checkouts/gecko/js/src/gc/GC.cpp:7151:9 (libxul.so+0x6c388e5)
[task 2020-03-16T22:39:55.399Z] 22:39:55     INFO - GECKO(1177) |     #18 js::gc::GCRuntime::gcSlice(JS::GCReason, long) /builds/worker/checkouts/gecko/js/src/gc/GC.cpp:7243:3 (libxul.so+0x6c3916a)
[task 2020-03-16T22:39:55.400Z] 22:39:55     INFO - GECKO(1177) |     #19 JS::IncrementalGCSlice(JSContext*, JS::GCReason, long) /builds/worker/checkouts/gecko/js/src/gc/GC.cpp:8073:21 (libxul.so+0x6c3c927)
[task 2020-03-16T22:39:55.400Z] 22:39:55     INFO - GECKO(1177) |     #20 nsJSContext::GarbageCollectNow(JS::GCReason, nsJSContext::IsIncremental, nsJSContext::IsShrinking, long) /builds/worker/checkouts/gecko/dom/base/nsJSEnvironment.cpp:1170:5 (libxul.so+0x2602b6a)
[task 2020-03-16T22:39:55.400Z] 22:39:55     INFO - GECKO(1177) |     #21 InterSliceGCRunnerFired(mozilla::TimeStamp, void*) /builds/worker/checkouts/gecko/dom/base/nsJSEnvironment.cpp:1741:3 (libxul.so+0x2608eb2)
[task 2020-03-16T22:39:55.401Z] 22:39:55     INFO - GECKO(1177) |     #22 operator() /builds/worker/checkouts/gecko/dom/base/nsJSEnvironment.cpp:2330:22 (libxul.so+0x26181cf)
[task 2020-03-16T22:39:55.402Z] 22:39:55     INFO - GECKO(1177) |     #23 std::_Function_handler<bool (mozilla::TimeStamp), DOMGCSliceCallback(JSContext*, JS::GCProgress, JS::GCDescription const&)::$_18>::_M_invoke(std::_Any_data const&, mozilla::TimeStamp&&) /builds/worker/fetches/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/7.4.0/../../../../include/c++/7.4.0/bits/std_function.h:301:9 (libxul.so+0x26181cf)
[task 2020-03-16T22:39:55.403Z] 22:39:55     INFO - GECKO(1177) |     #24 operator() /builds/worker/fetches/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/7.4.0/../../../../include/c++/7.4.0/bits/std_function.h:706:14 (libxul.so+0xa81c1e)
[task 2020-03-16T22:39:55.403Z] 22:39:55     INFO - GECKO(1177) |     #25 mozilla::IdleTaskRunner::Run() /builds/worker/checkouts/gecko/xpcom/threads/IdleTaskRunner.cpp:58:14 (libxul.so+0xa81c1e)
[task 2020-03-16T22:39:55.404Z] 22:39:55     INFO - GECKO(1177) |     #26 nsThread::ProcessNextEvent(bool, bool*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:1220:14 (libxul.so+0xaa3081)
[task 2020-03-16T22:39:55.405Z] 22:39:55     INFO - GECKO(1177) |     #27 NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:481:10 (libxul.so+0xaa7b22)
[task 2020-03-16T22:39:55.407Z] 22:39:55     INFO - GECKO(1177) |     #28 mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/glue/MessagePump.cpp:87:21 (libxul.so+0x12f8ab9)
[task 2020-03-16T22:39:55.407Z] 22:39:55     INFO - GECKO(1177) |     #29 mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/glue/MessagePump.cpp:270:30 (libxul.so+0x12f94cb)
[task 2020-03-16T22:39:55.408Z] 22:39:55     INFO - GECKO(1177) |     #30 RunInternal /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:315:10 (libxul.so+0x1289d0c)
[task 2020-03-16T22:39:55.409Z] 22:39:55     INFO - GECKO(1177) |     #31 RunHandler /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:308:3 (libxul.so+0x1289d0c)
[task 2020-03-16T22:39:55.410Z] 22:39:55     INFO - GECKO(1177) |     #32 MessageLoop::Run() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:290:3 (libxul.so+0x1289d0c)
[task 2020-03-16T22:39:55.410Z] 22:39:55     INFO - GECKO(1177) |     #33 nsBaseAppShell::Run() /builds/worker/checkouts/gecko/widget/nsBaseAppShell.cpp:137:27 (libxul.so+0x4745d83)
[task 2020-03-16T22:39:55.411Z] 22:39:55     INFO - GECKO(1177) |     #34 XRE_RunAppShell() /builds/worker/checkouts/gecko/toolkit/xre/nsEmbedFunctions.cpp:926:20 (libxul.so+0x639c119)
[task 2020-03-16T22:39:55.411Z] 22:39:55     INFO - GECKO(1177) |     #35 mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/glue/MessagePump.cpp:237:9 (libxul.so+0x12f947a)
[task 2020-03-16T22:39:55.411Z] 22:39:55     INFO - GECKO(1177) |     #36 RunInternal /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:315:10 (libxul.so+0x1289d0c)
[task 2020-03-16T22:39:55.411Z] 22:39:55     INFO - GECKO(1177) |     #37 RunHandler /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:308:3 (libxul.so+0x1289d0c)
[task 2020-03-16T22:39:55.412Z] 22:39:55     INFO - GECKO(1177) |     #38 MessageLoop::Run() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:290:3 (libxul.so+0x1289d0c)
[task 2020-03-16T22:39:55.413Z] 22:39:55     INFO - GECKO(1177) |     #39 XRE_InitChildProcess(int, char**, XREChildData const*) /builds/worker/checkouts/gecko/toolkit/xre/nsEmbedFunctions.cpp:761:34 (libxul.so+0x639be84)
[task 2020-03-16T22:39:55.413Z] 22:39:55     INFO - GECKO(1177) |     #40 mozilla::BootstrapImpl::XRE_InitChildProcess(int, char**, XREChildData const*) /builds/worker/checkouts/gecko/toolkit/xre/Bootstrap.cpp:67:12 (libxul.so+0x63a3ec2)
[task 2020-03-16T22:39:55.414Z] 22:39:55     INFO - GECKO(1177) |     #41 content_process_main /builds/worker/checkouts/gecko/browser/app/../../ipc/contentproc/plugin-container.cpp:56:28 (firefox+0xc86c7)
[task 2020-03-16T22:39:55.414Z] 22:39:55     INFO - GECKO(1177) |     #42 main /builds/worker/checkouts/gecko/browser/app/nsBrowserApp.cpp:303:18 (firefox+0xc86c7)
[task 2020-03-16T22:39:55.415Z] 22:39:55     INFO - GECKO(1177) |   Previous write of size 8 at 0x7f1ee2968350 by thread T8:
[task 2020-03-16T22:39:55.416Z] 22:39:55     INFO - GECKO(1177) |     [failed to restore the stack]
[task 2020-03-16T22:39:55.417Z] 22:39:55     INFO - GECKO(1177) |   Thread T8 'JS Helper' (tid=1310, running) created by main thread at:
[task 2020-03-16T22:39:55.418Z] 22:39:55     INFO - GECKO(1177) |     #0 pthread_create /builds/worker/fetches/llvm-project/llvm/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:967:3 (firefox+0x571ab)
[task 2020-03-16T22:39:55.419Z] 22:39:55     INFO - GECKO(1177) |     #1 js::Thread::create(void* (*)(void*), void*) /builds/worker/checkouts/gecko/js/src/threading/posix/PosixThread.cpp:52:7 (libxul.so+0x65e5023)
[task 2020-03-16T22:39:55.420Z] 22:39:55     INFO - GECKO(1177) |     #2 bool js::Thread::init<void (&)(void*), js::HelperThread*>(void (&)(void*), js::HelperThread*&&) /builds/worker/checkouts/gecko/js/src/threading/Thread.h:91:12 (libxul.so+0x66e2ff2)
[task 2020-03-16T22:39:55.421Z] 22:39:55     INFO - GECKO(1177) |     #3 js::GlobalHelperThreadState::ensureInitialized() /builds/worker/checkouts/gecko/js/src/vm/HelperThreads.cpp:1158:27 (libxul.so+0x66ddc21)
[task 2020-03-16T22:39:55.423Z] 22:39:55     INFO - GECKO(1177) |     #4 js::EnsureHelperThreadsInitialized() /builds/worker/checkouts/gecko/js/src/vm/HelperThreads.cpp:94:30 (libxul.so+0x66dd902)
[task 2020-03-16T22:39:55.424Z] 22:39:55     INFO - GECKO(1177) |     #5 JSRuntime::init(JSContext*, unsigned int) /builds/worker/checkouts/gecko/js/src/vm/Runtime.cpp:200:32 (libxul.so+0x67ef902)
[task 2020-03-16T22:39:55.425Z] 22:39:55     INFO - GECKO(1177) |     #6 js::NewContext(unsigned int, JSRuntime*) /builds/worker/checkouts/gecko/js/src/vm/JSContext.cpp:170:17 (libxul.so+0x672ce3d)
[task 2020-03-16T22:39:55.426Z] 22:39:55     INFO - GECKO(1177) |     #7 JS_NewContext(unsigned int, JSRuntime*) /builds/worker/checkouts/gecko/js/src/jsapi.cpp:390:10 (libxul.so+0x6572554)
[task 2020-03-16T22:39:55.427Z] 22:39:55     INFO - GECKO(1177) |     #8 mozilla::CycleCollectedJSContext::Initialize(JSRuntime*, unsigned int) /builds/worker/checkouts/gecko/xpcom/base/CycleCollectedJSContext.cpp:128:16 (libxul.so+0x9addfb)
[task 2020-03-16T22:39:55.427Z] 22:39:55     INFO - GECKO(1177) |     #9 XPCJSContext::Initialize() /builds/worker/checkouts/gecko/js/xpconnect/src/XPCJSContext.cpp:1079:32 (libxul.so+0x188716a)
[task 2020-03-16T22:39:55.429Z] 22:39:55     INFO - GECKO(1177) |     #10 XPCJSContext::NewXPCJSContext() /builds/worker/checkouts/gecko/js/xpconnect/src/XPCJSContext.cpp:1275:23 (libxul.so+0x1887cc7)
[task 2020-03-16T22:39:55.429Z] 22:39:55     INFO - GECKO(1177) |     #11 nsXPConnect::InitJSContext() /builds/worker/checkouts/gecko/js/xpconnect/src/nsXPConnect.cpp:80:25 (libxul.so+0x18c2c13)
[task 2020-03-16T22:39:55.429Z] 22:39:55     INFO - GECKO(1177) |     #12 xpc::InitializeJSContext() /builds/worker/checkouts/gecko/js/xpconnect/src/nsXPConnect.cpp:98:35 (libxul.so+0x18c2ccf)
[task 2020-03-16T22:39:55.430Z] 22:39:55     INFO - GECKO(1177) |     #13 NS_InitXPCOM /builds/worker/checkouts/gecko/xpcom/build/XPCOMInit.cpp:489:5 (libxul.so+0xad64ee)
[task 2020-03-16T22:39:55.430Z] 22:39:55     INFO - GECKO(1177) |     #14 XRE_InitEmbedding2(nsIFile*, nsIFile*, nsIDirectoryServiceProvider*) /builds/worker/checkouts/gecko/toolkit/xre/nsEmbedFunctions.cpp:199:8 (libxul.so+0x639b634)
[task 2020-03-16T22:39:55.430Z] 22:39:55     INFO - GECKO(1177) |     #15 mozilla::ipc::ScopedXREEmbed::Start() /builds/worker/checkouts/gecko/ipc/glue/ScopedXREEmbed.cpp (libxul.so+0x1307a03)
[task 2020-03-16T22:39:55.432Z] 22:39:55     INFO - GECKO(1177) |     #16 mozilla::dom::ContentProcess::Init(int, char**) /builds/worker/checkouts/gecko/dom/ipc/ContentProcess.cpp:181:13 (libxul.so+0x4334ffb)
[task 2020-03-16T22:39:55.432Z] 22:39:55     INFO - GECKO(1177) |     #17 XRE_InitChildProcess(int, char**, XREChildData const*) /builds/worker/checkouts/gecko/toolkit/xre/nsEmbedFunctions.cpp:727:21 (libxul.so+0x639be5d)
[task 2020-03-16T22:39:55.433Z] 22:39:55     INFO - GECKO(1177) |     #18 mozilla::BootstrapImpl::XRE_InitChildProcess(int, char**, XREChildData const*) /builds/worker/checkouts/gecko/toolkit/xre/Bootstrap.cpp:67:12 (libxul.so+0x63a3ec2)
[task 2020-03-16T22:39:55.433Z] 22:39:55     INFO - GECKO(1177) |     #19 content_process_main /builds/worker/checkouts/gecko/browser/app/../../ipc/contentproc/plugin-container.cpp:56:28 (firefox+0xc86c7)
[task 2020-03-16T22:39:55.435Z] 22:39:55     INFO - GECKO(1177) |     #20 main /builds/worker/checkouts/gecko/browser/app/nsBrowserApp.cpp:303:18 (firefox+0xc86c7)
[task 2020-03-16T22:39:55.436Z] 22:39:55     INFO - GECKO(1177) | SUMMARY: ThreadSanitizer: data race /builds/worker/checkouts/gecko/js/src/vm/Shape.h:863:10 in baseUnowned
[task 2020-03-16T22:39:55.436Z] 22:39:55     INFO - GECKO(1177) | ==================
[task 2020-03-16T22:39:55.898Z] 22:39:55    ERROR - GECKO(1177) | A content process crashed and MOZ_CRASHREPORTER_SHUTDOWN is set, shutting down
[task 2020-03-16T22:39:59.207Z] 22:39:59     INFO - GECKO(1177) | 1584398399196	Marionette	TRACE	Received observer notification xpcom-will-shutdown
[task 2020-03-16T22:39:59.208Z] 22:39:59     INFO - GECKO(1177) | 1584398399197	Marionette	INFO	Stopped listening on port 2828
[task 2020-03-16T22:39:59.208Z] 22:39:59     INFO - GECKO(1177) | 1584398399198	Marionette	DEBUG	Marionette stopped listening
[task 2020-03-16T22:40:00.529Z] 22:40:00     INFO - TEST-INFO | Main app process: exit 0
[task 2020-03-16T22:40:00.530Z] 22:40:00     INFO - runtests.py | Application ran for: 0:06:40.366735
[task 2020-03-16T22:40:00.531Z] 22:40:00     INFO - zombiecheck | Reading PID log: /tmp/tmpVyjY2Rpidlog
[task 2020-03-16T22:40:00.531Z] 22:40:00     INFO - ==> process 1177 launched child process 1196
[task 2020-03-16T22:40:00.531Z] 22:40:00     INFO - ==> process 1177 launched child process 1235
[task 2020-03-16T22:40:00.533Z] 22:40:00     INFO - ==> process 1177 launched child process 1300
[task 2020-03-16T22:40:00.533Z] 22:40:00     INFO - ==> process 1177 launched child process 1355
[task 2020-03-16T22:40:00.533Z] 22:40:00     INFO - ==> process 1177 launched child process 1380
[task 2020-03-16T22:40:00.534Z] 22:40:00     INFO - zombiecheck | Checking for orphan process with PID: 1300
Component: JavaScript Engine → JavaScript: GC

Christian, do you have any insights for these tsan failures? There are already 177 failures since this was filed on the 16th: https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2020-03-13&endday=2020-03-20&tree=trunk&bug=1622969
Thank you.

Flags: needinfo?(choller)

Jon, this looks like a potential duplicate to one of the previous JS GC races you looked at (the second stack missing is an indicator that it is suppressed by one of the previous bugs that aren't solved yet). Can you tell from the one stack which duplicate this might be? Should we try to reproduce this locally somehow?

Flags: needinfo?(choller) → needinfo?(jcoppeard)

Uh, I double checked the change I landed, and I'm not seeing anything touching JS/GC. And that code is nowhere in the call stacks.
Given the bug component is outside of my domain, not sure how I can help here. As the last resort, if everything else fails, we may try re-landing the patch in pieces.

Flags: needinfo?(dmalyshau)

I think this is a duplicate of bug 1600895, with a different way of reading the first field of a shape.

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(jcoppeard)
Resolution: --- → DUPLICATE

This race is between reading a shape's base shape on the main thread and a write on another thread. Shape update only happens on the main thread and therefore I don't think this is the same issue as bug 1600895 any more.

Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee: nobody → jcoppeard
Whiteboard: [stockwell disable-recommended] → [stockwell needswork]
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/260943877d93
Improve assertions about when compacting GC can update pointers on background threads r=sfink

https://hg.mozilla.org/mozilla-central/rev/260943877d93

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76

That was just adding assertions, not a fix.

Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
Target Milestone: mozilla76 → ---
Summary: Intermittent GECKO(1177) | SUMMARY: ThreadSanitizer: data race /builds/worker/checkouts/gecko/js/src/vm/Shape.h:863:10 in baseUnowned → Intermittent SUMMARY: ThreadSanitizer: data race /builds/worker/checkouts/gecko/js/src/vm/Shape.h:863:10 in baseUnowned

This code has been removed by the PropMap changes.

Status: REOPENED → RESOLVED
Closed: 4 years ago → 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: