Closed Bug 1622972 Opened 5 months ago Closed 5 months ago

Python 3 compatibility fixes for Thunderbird

Categories

(Thunderbird :: Build Config, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 76.0

People

(Reporter: rjl, Assigned: rjl)

References

Details

Attachments

(1 file)

A number of Python scripts in comm-central fail basic Python compatibility mozlint tests. This list of files are all relatively easy fixes, just need some future imports to make the tests happy.

/builds/worker/checkouts/gecko/comm/build/source_repos.py:5:1 | Missing from __future__ import absolute_import (require absolute_import)
/builds/worker/checkouts/gecko/comm/calendar/lightning/repack/modify-manifest.py:1:1 | Missing from __future__ import absolute_import (require absolute_import)
/builds/worker/checkouts/gecko/comm/calendar/lightning/repack/webextify.py:1:1 | Missing from __future__ import absolute_import (require absolute_import)
/builds/worker/checkouts/gecko/comm/calendar/locales/filter.py:1:1 | Missing from __future__ import absolute_import (require absolute_import)
/builds/worker/checkouts/gecko/comm/mail/locales/filter.py:1:1 | Missing from __future__ import absolute_import (require absolute_import)
/builds/worker/checkouts/gecko/comm/mail/test/marionette/test_addressbook.py:7:1 | Missing from __future__ import absolute_import (require absolute_import)
/builds/worker/checkouts/gecko/comm/mail/test/marionette/test_empty.py:5:1 | Missing from __future__ import absolute_import (require absolute_import)
/builds/worker/checkouts/gecko/comm/mozharness/repackage/base.py:1:1 | Missing from __future__ import absolute_import (require absolute_import)
Fixes for mozlint Python-compatibility test. These files all needed some
future imports.
Attachment #9133730 - Flags: review?(geoff)
Assignee: nobody → rob
Status: NEW → ASSIGNED
Comment on attachment 9133730 [details] [diff] [review]
Fix python-compatibility test errors

Review of attachment 9133730 [details] [diff] [review]:
-----------------------------------------------------------------

These files should probably all have licence blocks. :-/
Attachment #9133730 - Flags: review?(geoff) → review+

Yes... Once bug 1622974 lands we can run all of the mozlint tests including the license check one so that is coming...

Target Milestone: --- → Thunderbird 76.0

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/c8aea2febde1
Fix python-compatibility test errors. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Blocks: 1628506
You need to log in before you can comment on or make changes to this bug.