Open Bug 1623068 Opened 5 years ago Updated 2 years ago

gecko-profiler-interfaces.js shouldn't specify the "responsiveness" feature by default

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

defect

Tracking

(Not tracked)

People

(Reporter: julienw, Unassigned)

Details

Attachments

(1 obsolete file)

The "responsiveness" feature has been removed recently, but is still specified in gecko-profiler-interface.js. As a result this gives some unneeded logs in some tests.

Assignee: nobody → felash
Status: NEW → ASSIGNED

The priority flag is not set for this bug.
:julienw, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(felash)
Flags: needinfo?(felash)
Priority: -- → P3

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:julienw, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(felash)

yes, I know :-)

Flags: needinfo?(felash)

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Assignee: felash → nobody
Severity: normal → S3
Status: ASSIGNED → NEW

The phabricator review is still showing up in my bug review dashboards. Is the patch here still valid?

Flags: needinfo?(felash)
Assignee: nobody → felash
Status: NEW → ASSIGNED

I believe it is, just it was difficult to context switch back to this. I'll make sure to land this soon.

Flags: needinfo?(felash)

(actually keeping a needinfo)

Flags: needinfo?(felash)
Attachment #9134154 - Attachment is obsolete: true

The patch in this bug is too complex for what we want to do here. We only want to remove the "responsiveness" feature from the codebase. So I marked it abandoned. I also don't expect to work on this soon, but I believe this is still something we want to do. We may wait until Bug 1603246 to remove all references in one go (see also bug 1594566).

Assignee: felash → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(felash)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: