Closed Bug 1623080 Opened 2 years ago Closed 2 years ago

138.44% build times (linux64) regression on push 469d7894f720cc63692dd23c9e0e9ace73bb9fbf (Tue March 3 2020)

Categories

(Core :: Panning and Zooming, defect)

defect
Not set
normal

Tracking

()

RESOLVED INVALID
mozilla75
Tracking Status
thunderbird_esr60 --- unaffected
thunderbird_esr68 --- unaffected
firefox-esr68 --- unaffected
firefox74 --- unaffected
firefox75 --- wontfix
firefox76 --- wontfix

People

(Reporter: marauder, Unassigned)

References

(Regression)

Details

(Keywords: perf-alert, regression)

A few notes here:

  • the graph doesn't show all the data points, but in treeherder we can see all the jobs
  • the regression occured on 469d7894f720cc63692dd23c9e0e9ace73bb9fbf [1]
    where "build times tsan taskcluster-c5.4xlarge tsan-fuzzing" is 1286.72

https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=Linux%2Cx64%2Ctsan%2Cbuild-linux64-tsan-fuzzing%2Fopt%2C%28Bof%29&tochange=4e5d74671e9808551f118863569dcfb972787ad0&fromchange=c59bd8d0d397bccd54d0e78ba8e1a6d00d4fad58&selectedJob=291427935

  • the data point d1cc91327f3f which is before the changeset from [1], has:
    build times tsan taskcluster-c5d.4xlarge tsan-fuzzing: 483.63
  • the data point 9cf4382f8882 which is after the changeset from [1], has:
    build times tsan taskcluster-c5d.4xlarge tsan-fuzzing: 1054.38

Graph view:
https://treeherder.mozilla.org/perf.html#/graphs?highlightAlerts=1&highlightedRevisions=d1cc&series=autoland,2153778,1,2&timerange=2592000&zoom=1583224869378,1583240878593,418.30624668592816,1755.701118426722

Because the data point where the regression occurred is not visible on the graph, i could not create a new alert and reassign the one opened by perfherder for 9cf4382f88826.


We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=469d7894f720cc63692dd23c9e0e9ace73bb9fbf

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

138% build times linux64 tsan taskcluster-c5d.4xlarge tsan-fuzzing 498.40 -> 1,188.39

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=25418

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Component: Performance → Panning and Zooming
Product: Testing → Core
Summary: 138.44% build times (linux64) regression on push 9cf4382f88826e7d458a1a9ec8b8470c9652cd83 (Tue March 3 2020) → 138.44% build times (linux64) regression on push 469d7894f720cc63692dd23c9e0e9ace73bb9fbf (Tue March 3 2020)
Target Milestone: --- → mozilla75
Version: Version 3 → unspecified

A few updates:
Looking at the jobs in treeherder we can see that on the backout for 469d7894f720cc63692dd23c9e0e9ace73bb9fbf :
82e82612011b - Backed out changeset 469d7894f720 (Bug 1618545) for causing bustages in src/layout/base/PositionedEventTargeting.cpp

  • the value for "build times tsan taskcluster-c5.4xlarge tsan-fuzzing" is 1137.52 , which is still high so it seems that the main changeset is not related to the regression.

Considering the noise from the graph it's also an option to close this bug as invalid/won't fix.

Blocks: 1614561
Flags: needinfo?(kats)
Flags: needinfo?(botond)
Regressed by: 1618545
Has Regression Range: --- → yes

Yeah that graph looks really noisy. The patch in question mostly deleted a bunch of code so it's quite improbable that it caused an increase in compiler time. I think this one should get closed as invalid.

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(kats)
Flags: needinfo?(botond)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.