1623085 - Only explicitly set number of Rust codegen-units for target artifacts

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Michael Woerister]

At the moment we set codegen-units = 1 in the release profile of the top-level Cargo.toml. The codegen-units = 1 setting produces more optimized code but is unnecessary for host artifacts. When setting codegen-units = 1 only for target artifacts the --enable-release build time goes from 20m 30s to 19m 30s on my machine.

Another reason to remove the codegen-units setting from the Cargo.toml is that it will negatively affect incremental compilation for DEVELOPER_OPTIONS builds if https://github.com/rust-lang/compiler-team/issues/245 gets accepted in the Rust compiler. See https://bugzilla.mozilla.org/show_bug.cgi?id=1613649 for more information on that.

Comment 1

[Michael Woerister]

Attachment: Bug 1623085 - Only explicitly set number of Rust codegen-units for target artifacts.

Comment 2

[(Away)]

How come this depends on bug 1602810?

Comment 3

[Michael Woerister]

How come this depends on bug 1602810?

Whoops, I created this bug by initially cloning bug 1602810 and forgot to clean up.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c698df62e0d
Only explicitly set number of Rust codegen-units for target artifacts. r=froydnj

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3c698df62e0d