Closed Bug 1623085 Opened 4 years ago Closed 4 years ago

Only explicitly set number of Rust codegen-units for target artifacts

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox76 fixed)

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: mwoerister, Assigned: mwoerister)

Details

Attachments

(1 file)

At the moment we set codegen-units = 1 in the release profile of the top-level Cargo.toml. The codegen-units = 1 setting produces more optimized code but is unnecessary for host artifacts. When setting codegen-units = 1 only for target artifacts the --enable-release build time goes from 20m 30s to 19m 30s on my machine.

Another reason to remove the codegen-units setting from the Cargo.toml is that it will negatively affect incremental compilation for DEVELOPER_OPTIONS builds if https://github.com/rust-lang/compiler-team/issues/245 gets accepted in the Rust compiler. See https://bugzilla.mozilla.org/show_bug.cgi?id=1613649 for more information on that.

Assignee: nobody → mwoerister
Status: NEW → ASSIGNED

How come this depends on bug 1602810?

No longer depends on: 1602810
No longer blocks: 1602568

How come this depends on bug 1602810?

Whoops, I created this bug by initially cloning bug 1602810 and forgot to clean up.

Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3c698df62e0d
Only explicitly set number of Rust codegen-units for target artifacts. r=froydnj
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: