Only explicitly set number of Rust codegen-units for target artifacts
Categories
(Firefox Build System :: General, enhancement)
Tracking
(firefox76 fixed)
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: mwoerister, Assigned: mwoerister)
Details
Attachments
(1 file)
At the moment we set codegen-units = 1
in the release profile of the top-level Cargo.toml
. The codegen-units = 1
setting produces more optimized code but is unnecessary for host artifacts. When setting codegen-units = 1
only for target artifacts the --enable-release
build time goes from 20m 30s to 19m 30s on my machine.
Another reason to remove the codegen-units
setting from the Cargo.toml
is that it will negatively affect incremental compilation for DEVELOPER_OPTIONS builds if https://github.com/rust-lang/compiler-team/issues/245 gets accepted in the Rust compiler. See https://bugzilla.mozilla.org/show_bug.cgi?id=1613649 for more information on that.
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
How come this depends on bug 1602810?
Assignee | ||
Comment 3•4 years ago
|
||
How come this depends on bug 1602810?
Whoops, I created this bug by initially cloning bug 1602810 and forgot to clean up.
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3c698df62e0d Only explicitly set number of Rust codegen-units for target artifacts. r=froydnj
Comment 5•4 years ago
|
||
bugherder |
Description
•