Closed Bug 1623125 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 22303 - (Declarative Shadow DOM) Use shadowroot attribute value from open tag

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22303 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22303
Details from upstream follow.

Mason Freed <masonfreed@chromium.org> wrote:

(Declarative Shadow DOM) Use shadowroot attribute value from open tag

Prior to this CL, the "shadowroot" attribute from the \<template>
DOM node would be read back upon encountering the closing tag,
to determine whether to attach a shadow root. To better align with
the spec, With this CL, the opening \<template shadowroot>
tag "shadowroot" attribute is read, and stored for use when the
closing tag is encountered.

This CL also starts to add testing of declarative shadow DOM.

Bug: 1042130
Change-Id: I0f52a3baa4c1f11d4cce7d1001ec80a31f139e48
Reviewed-on: https://chromium-review.googlesource.com/2106737
WPT-Export-Revision: 1281a064ba26126136b857109803fb7444e61d5c

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 47 tests

Status Summary

Firefox

OK : 1
PASS: 1[GitHub] 47[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 4

Chrome

OK : 1
PASS: 5

Safari

OK : 1
PASS: 1
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/shadow-dom/declarative/declarative-shadow-dom.tentative.html
Declarative Shadow DOM: Missing closing tag: FAIL (Chrome: PASS, Safari: FAIL)
Declarative Shadow DOM: Fragment parser basic test: FAIL (Chrome: PASS, Safari: FAIL)
Declarative Shadow DOM: Closed shadow root attribute: FAIL (Chrome: PASS, Safari: FAIL)
Declarative Shadow DOM: Basic test: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5fa0bf23c496
[wpt PR 22303] - (Declarative Shadow DOM) Use shadowroot attribute value from open tag, a=testonly
https://hg.mozilla.org/integration/autoland/rev/de84897b1416
[wpt PR 22303] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/5fa0bf23c496
https://hg.mozilla.org/mozilla-central/rev/de84897b1416

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.