1623173 - Preserve embedderDisabled when rebuilding addon DB

Status: VERIFIED FIXED

(GeckoView :: Extensions, defect, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

:rpl helped me with this. Right now when upgrading major versions we lose that property and the addons are enabled, see: https://github.com/mozilla-mobile/android-components/issues/6255

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

To verify the fix:

install Fennec
Install a non-supported addon like Privacy Badger
Update to a Fenix version that's on Gecko 75
start fenix, verify privacy badger is not enabled
Update to latest fenix (so Gecko 76)
Notice privacy badger is disabled (right now it's enabled)

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1623173 - Preserve embedderDisabled when rebuilding addon DB.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86830c2de974
Preserve embedderDisabled when rebuilding addon DB. r=mixedpuppy

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/86830c2de974

Comment 5

[[ex-Mozilla] Agi Sferro | :agi]

Comment on attachment 9133978 [details]
Bug 1623173 - Preserve embedderDisabled when rebuilding addon DB.

Beta/Release Uplift Approval Request

• User impact if declined: Some addons will be enabled in Fenix that should not be enabled.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just adding a new field to the db migration code
• String changes made/needed:

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9133978 [details]
Bug 1623173 - Preserve embedderDisabled when rebuilding addon DB.

fix an issue with addons on fenix, approved for 75.0b6

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/acaaaac29f9f

Comment 8

[Eliza Balazs]

Hi! I could reproduce this on Pixel 2 (Android 9) and Huawei P9 Lite (Android 7) following the steps:

1. Install Fennec Nightly;
2. Install unsupported add-ons, Privacy Badger, Ghostery, NoScript;
3. Migrate to Fenix Nightly from 3/4 GV 75;
4. Update to a build from 3/15 GV 76;

Using the latest Fennec Nightly Migration build from 3/23 GV 76, the unsupported add-ons are not active and are not displayed in the menu.
Due to this I will mark this as verified on Nightly GV 76.

Comment 9

[Eliza Balazs]

This is not reproducible on Beta migration 75.0.0-beta.2 GV 75 from 3/25 with Pixel 2 (Android 9) and Huawei P9 Lite (Android 7).
Due to this I will mark this as Verified.