1623276 - New events do not appear in the Today Pane with a cached calDAV calendar

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect, P1)

Description

[Geoff Lankow (:darktrojan)]

In bug 1585230 I introduced a flag to stop the Today Pane adding events individually and instead load them all together when loading was complete.

However the calDAV provider with offline cache does not fire the onLoad event (when adding a new event, possibly other times) which clears the flag and refreshes the view. This prevents any further new events from appearing in the pane.

Comment 1

[Magnus Melin [:mkmelin]]

I think I've seen this in the main views too? Or something similar where calendars for some reasons refuse to show new events.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1623276-onendbatch-1.diff

Fixing the caldav provider is more difficult than it looks. I did what I had in mind when I filed this bug (IIRC) and it went crazy, continuously hitting the server. An easier fix in the short term is to refresh the list at onEndBatch instead of onLoad. It's potentially not as good for performance but at least it works.

Comment 3

[Paul Morris [:pmorris]]

Comment on attachment 9157895 [details] [diff] [review]
1623276-onendbatch-1.diff

Review of attachment 9157895 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1141a5e07869
Refresh agenda and unifinder in onEndBatch instead of onLoad. r=pmorris

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 78.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/2e2037a68812