Implement the Rust General API for FOG
Categories
(Toolkit :: Telemetry, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: janerik, Assigned: janerik)
References
Details
(Whiteboard: [telemetry:fog:m3])
Attachments
(5 files)
This is the implementation bug for implementing the full Rust general API for Project FOG.
It will have multiple smaller subtasks to split up the work in smaller chunks.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
This also upgrades the vendored Glean version, which thanks to our
upstream work doesn't change anything else (except one small
Mozilla-developed dependency)
It's still feature-gated to nightly.
In C++ there's now a MOZ_GLEAN define.
For Rust it's behind the glean feature (enabled on nightly only).
The fog crate is empty, so no Glean is actually instantiated.
|
|
Assignee | |
Comment 2•4 years ago
|
||
This passes on dummy values for now.
Still no Glean is initialized, and thus no data placed on disk (and no
temporary or additional profile directories created).
It's done that way to ensure it's actually compiled and called (and make
local development easier).
Depends on D68539
|
|
Assignee | |
Comment 3•4 years ago
|
||
We can re-use the glean_core configuration now.
Depends on D68540
|
|
Assignee | |
Comment 4•4 years ago
|
||
Controlling is two things:
- initializing Glean
- toggling upload enabled.
Initializing also means setting the internal metrics (client info), some
of which we detect at build time.
Upload enabled will eventualy be bound to the Firefox preference be
flipped.
Depends on D68542
|
|
Assignee | |
Comment 5•4 years ago
|
||
Document the in-progress code layout in-tree
Depends on D68543
Pushed by jrediger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d2673451da54 Replace fogotype with the actual FOG crate now. r=chutten https://hg.mozilla.org/integration/autoland/rev/c04dbe8dd337 Init Glean from old Telemetry. r=chutten https://hg.mozilla.org/integration/autoland/rev/cbcb3bb23090 Add configuration for Glean. r=chutten https://hg.mozilla.org/integration/autoland/rev/45fadf903140 Implement the remaining parts of the control API. r=chutten https://hg.mozilla.org/integration/autoland/rev/5267e6e2015d Add documentation about FOG code organization. r=chutten
|
||
Comment 7•4 years ago
|
||
Backed out for build bustages.
Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=5267e6e2015da0645ee05ad8a200a9f851b4afdd&selectedJob=295541258
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295541258&repo=autoland&lineNumber=44269
Backout: https://hg.mozilla.org/integration/autoland/rev/69c0965d862396a4c04f91ac98421ee1bd13ecca
|
|
Assignee | |
Comment 8•4 years ago
|
||
Failed to dead code. For now disabling the lint for that part of the code. We will start using it in the next round of patches coming.
Pushed by jrediger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e23c928bd6c7 Replace fogotype with the actual FOG crate now. r=chutten https://hg.mozilla.org/integration/autoland/rev/fb8612ded5ac Init Glean from old Telemetry. r=chutten https://hg.mozilla.org/integration/autoland/rev/216db028c7d4 Add configuration for Glean. r=chutten https://hg.mozilla.org/integration/autoland/rev/8ce8592bd3e2 Implement the remaining parts of the control API. r=chutten https://hg.mozilla.org/integration/autoland/rev/50d226c196bc Add documentation about FOG code organization. r=chutten
|
||
Comment 10•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e23c928bd6c7
https://hg.mozilla.org/mozilla-central/rev/fb8612ded5ac
https://hg.mozilla.org/mozilla-central/rev/216db028c7d4
https://hg.mozilla.org/mozilla-central/rev/8ce8592bd3e2
https://hg.mozilla.org/mozilla-central/rev/50d226c196bc
Description
•