Closed
Bug 162331
Opened 23 years ago
Closed 23 years ago
Memory leak in wallet_ReadFromList
Categories
(Toolkit :: Form Manager, defect, P2)
Toolkit
Form Manager
Tracking
()
RESOLVED
FIXED
People
(Reporter: dbradley, Unassigned)
Details
(Keywords: memory-leak)
Attachments
(1 file)
|
545 bytes,
patch
|
dbradley
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
The patch for bug 113158 introduced a memory leak in wallet_ReadFromList.
http://lxr.mozilla.org/seamonkey/source/extensions/wallet/src/wallet.cpp#1070
PL_strdup's a string and assigns that to item1 which is an nsACString. Which
will make a copy of it's own and leave the string created by PL_strdup leaked.
|
||
Comment 2•23 years ago
|
||
I presume that the line you are referring to is
item2 = PL_strdup(mapElementPtr->item2);
although that is line 1072 and it refers to item2, not item1
|
|
||
Comment 3•23 years ago
|
||
|
Reporter | |
Comment 4•23 years ago
|
||
Comment on attachment 96099 [details] [diff] [review]
remove PL_strdup
r=dbradley
Attachment #96099 -
Flags: review+
|
||
Comment 5•23 years ago
|
||
Comment on attachment 96099 [details] [diff] [review]
remove PL_strdup
sr=jag
Attachment #96099 -
Flags: superreview+
|
|
||
Comment 6•23 years ago
|
||
This was checked in on Aug 21. Forgot to close the bug report.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Assignee: morse → nobody
Product: Core → Toolkit
QA Contact: tpreston → form.manager
Target Milestone: mozilla1.2beta → ---
Version: Trunk → unspecified
You need to log in
before you can comment on or make changes to this bug.
Description
•