Closed
Bug 1623486
Opened 4 years ago
Closed 4 years ago
Always control the media being used in PIP
Categories
(Core :: Audio/Video: Playback, task, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla76
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
Details
Attachments
(6 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
I'm considering that, if a user is watching a video via PIP mode, then the tab that video belongs to should always be the main controller.
That means we would always control that media, even if there are other tabs playing media, which start later than when PIP video starts.
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
Assignee | ||
Comment 3•4 years ago
|
||
Assignee | ||
Comment 4•4 years ago
|
||
Assignee | ||
Comment 5•4 years ago
|
||
Assignee | ||
Comment 6•4 years ago
|
||
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d8d5c8f4af49 part1 : add methods to set/get the status of being in PIP mode or not for media controller. r=chunmin https://hg.mozilla.org/integration/autoland/rev/8c9263f17ba9 part2 : update main controller when controller starts being used in Picture-in-Picture mode. r=chunmin https://hg.mozilla.org/integration/autoland/rev/369779fb2393 part3 : add a method on ContentMediaController to propagate Picture-in-Picture status to the chrome process. r=chunmin https://hg.mozilla.org/integration/autoland/rev/55e660e894c6 part4 : update Picture-in-Picture mode status from media element. r=chunmin,padenot https://hg.mozilla.org/integration/autoland/rev/83a8fdfd1567 part5 : add test. r=chunmin https://hg.mozilla.org/integration/autoland/rev/4b30d2c68966 part6 : modify test. r=chunmin
Comment 8•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d8d5c8f4af49
https://hg.mozilla.org/mozilla-central/rev/8c9263f17ba9
https://hg.mozilla.org/mozilla-central/rev/369779fb2393
https://hg.mozilla.org/mozilla-central/rev/55e660e894c6
https://hg.mozilla.org/mozilla-central/rev/83a8fdfd1567
https://hg.mozilla.org/mozilla-central/rev/4b30d2c68966
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in
before you can comment on or make changes to this bug.
Description
•