1623581 - Add support for "returnByValue" and "awaitPromise" to Runtime.evaluate

Status: RESOLVED FIXED

(Remote Protocol :: CDP, task, P1)

Description

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Puppeteer uses it in _evaluateInternal() (ExecutionContext.js) with the value set to both true and false. We should implement that given that it is part of Runtime.evaluate and highly used.

I will do it beside the work on bug 1623484.

Comment 1

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

As noticed we also miss waitPromise, which actually can cause hanging promises and as result crashing Puppeteer unit tests. As seen lately that happens a lot for waitForSelector(). As such lets also get it implemented here, which basically is hopefully a copy and paste from Runtime.callFunctionOn only.

Comment 2

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d73bc8671851e5293f69dbc165ec57b7ae374f7a

Comment 3

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Attachment: Bug 1623581 - [remote] Refactor Runtime.evaluate and Runtime.callFunctionOn browser chrome tests.

Tests are mixing APIs between each other, which this patch removes.

Also error messages have been adjusted for both methods to
be on par with Chrome.

Comment 4

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Attachment: Bug 1623581 - [remote] Add "returnByValue" support to Runtime.evaluate.

Depends on D67840

Comment 5

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Attachment: Bug 1623581 - [remote] Add "awaitPromise" support to Runtime.evaluate.

Depends on D67841

Comment 6

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Attachment: Bug 1623581 - [puppeteer] Update expected tests for Puppeteer.

Depends on D67843

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f32172ae499
[remote] Refactor Runtime.evaluate and Runtime.callFunctionOn browser chrome tests. r=remote-protocol-reviewers,maja_zf
https://hg.mozilla.org/integration/autoland/rev/36920c4ef850
[remote] Add "returnByValue" support to Runtime.evaluate. r=remote-protocol-reviewers,maja_zf
https://hg.mozilla.org/integration/autoland/rev/c92f0faccdb5
[remote] Add "awaitPromise" support to Runtime.evaluate. r=remote-protocol-reviewers,maja_zf
https://hg.mozilla.org/integration/autoland/rev/bebf8622dd3b
[puppeteer] Update expected tests for Puppeteer. r=remote-protocol-reviewers,maja_zf

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/9f32172ae499
https://hg.mozilla.org/mozilla-central/rev/36920c4ef850
https://hg.mozilla.org/mozilla-central/rev/c92f0faccdb5
https://hg.mozilla.org/mozilla-central/rev/bebf8622dd3b