Closed Bug 1623602 Opened 4 months ago Closed 4 months ago

Perma SM TEST-UNEXPECTED-FAIL | non262/TypedArray/slice-memcpy.js when Gecko 76 merges to Beta on 2020-04-06

Categories

(Core :: JavaScript Engine, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla76
Tracking Status
firefox-esr68 --- unaffected
firefox74 --- unaffected
firefox75 --- unaffected
firefox76 + verified

People

(Reporter: noemi_erli, Assigned: lth)

References

(Regression)

Details

Attachments

(1 file)

[Tracking Requested - why for this release]:

Centra as Beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=8a98f330ea950ae71c4733ccc7d578bf577d4c3e&selectedJob=293835056

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293835056&repo=try&lineNumber=44221
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293835053&repo=try&lineNumber=47378

[task 2020-03-19T11:38:55.901Z] TEST-PASS | non262/TypedArray/constructor-iterable-nonpacked-array.js | (args: "") [0.1 s]
[task 2020-03-19T11:38:55.917Z] ## non262/TypedArray/slice-memcpy.js: rc = 3, run time = 0.128661
[task 2020-03-19T11:38:55.917Z] /builds/worker/workspace/build/src/js/src/tests/non262/TypedArray/slice-memcpy.js:57:18 ReferenceError: SharedArrayBuffer is not defined
[task 2020-03-19T11:38:55.917Z] Stack:
[task 2020-03-19T11:38:55.917Z] @/builds/worker/workspace/build/src/js/src/tests/non262/TypedArray/slice-memcpy.js:79:22
[task 2020-03-19T11:38:55.917Z] TEST-UNEXPECTED-FAIL | non262/TypedArray/slice-memcpy.js | (args: "") [0.1 s]
[task 2020-03-19T11:38:55.925Z] TEST-PASS | non262/TypedArray/includes.js | (args: "") [0.2 s]
[task 2020-03-19T11:38:55.926Z] TEST-PASS | non262/TypedArray/lastIndexOf-never-returns-negative-zero.js | (args: "") [0.1 s]
[task 2020-03-19T11:38:55.926Z] TEST-PASS | non262/TypedArray/getter-name.js | (args: "") [0.1 s]
[task 2020-03-19T11:38:55.985Z] TEST-PASS | non262/TypedArray/sort_snans.js | (args: "") [0.2 s]
[task 2020-03-19T11:38:55.985Z] TEST-PASS | non262/TypedArray/set-wrapped.js | (args: "") [0.1 s]
[task 2020-03-19T11:38:56.001Z] TEST-PASS | non262/TypedArray/iterator.js | (args: "") [0.1 s]
[task 2020-03-19T11:38:56.002Z] TEST-PASS | non262/TypedArray/fill-detached.js | (args: "") [0.1 s]
[task 2020-03-19T11:38:56.018Z] TEST-PASS | non262/TypedArray/from_realms.js | (args: "") [0.2 s]

Flags: needinfo?(lhansen)

Yeah, this has a guard but the guard is insufficient given the latest turbulence around SharedArrayBuffer. I'll try to get it fixed today.

Assignee: nobody → lhansen
Status: NEW → ASSIGNED
Flags: needinfo?(lhansen)

Not regressed by bug 1621933 but really by bug 1566427, for the same reasons as bug 1621933 -- technically not a regression but a case of exposing a pre-existing bug in this test case.

An earlier change would disable SharedArrayBuffer in the JS shell for beta and release builds.
This has uncovered some broken guards in various test cases, in this case, a test on whether
the shell built-in setSharedObject is available. However, that is not affected by the change
in the setting, so the guard really should test both setSharedObject (to ensure it's only
tested in the shell) and SharedArrayBuffer (to ensure it's only tested when shared memory
is available.)

Priority: -- → P1
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86267e092be2
Properly guard a test case.  r=rhunt
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.