1623637 - Split UrlbarProviderSuggestions out from UnifiedComplete

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Harry Twyford]

We'll start with splitting UrlbarProviderSuggestions out from UnifiedComplete. Marco expects this will be the easiest result type to port. This work will give us a better idea of the difficulties we might face as we port other result types into a UrlbarProvider.

Comment 1

[Harry Twyford]

Attachment: Bug 1623637 - Part 1 - Fix race in PlacesSearchAutocompleteProvider.

Comment 2

[Harry Twyford]

Attachment: Bug 1623637 - Part 2 - Add UrlbarProviderSearchSuggestions.jsm.

Depends on D69696

Comment 3

[Harry Twyford]

Attachment: Bug 1623637 - Part 3 - Remove suggestions code from UnifiedComplete and enable UrlbarProviderSearchSuggestions.

Depends on D69697

Comment 4

[Harry Twyford]

Attachment: Bug 1623637 - Part 4 - Move addBookmark helper to PlacesTestUtils.

Depends on D69698

Comment 5

[Harry Twyford]

Attachment: Bug 1623637 - Part 5 - Port test_search_suggestions.js.

Depends on D69699

Comment 6

[Harry Twyford]

Attachment: Bug 1623637 - Part 6 - Port part of search_suggestions_aliases.js.

Depends on D69700

Comment 7

[Harry Twyford]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=967747d872a45a8dcf8fbe31cb831277ac58a4d7

Comment 8

[Harry Twyford]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=783a182651918d52ae1bdc7779a422721b087e22

Comment 9

[Harry Twyford]

Try run of the final r+'d patches: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a48d0f5cf8d9903e20361f4055048a7757e13506

Update: Treeherder hit an exception. Let's try again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6efde71ebd78c123f5ae9a44ba9d228f3f7cbf0

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aeb4b6a030f7
Part 1 - Fix race in PlacesSearchAutocompleteProvider. r=mak
https://hg.mozilla.org/integration/autoland/rev/42402e0a35c5
Part 2 - Add UrlbarProviderSearchSuggestions.jsm. r=mak
https://hg.mozilla.org/integration/autoland/rev/27c5961fc195
Part 3 - Remove suggestions code from UnifiedComplete and enable UrlbarProviderSearchSuggestions. r=mak
https://hg.mozilla.org/integration/autoland/rev/c479ea11c586
Part 4 - Move addBookmark helper to PlacesTestUtils. r=mak
https://hg.mozilla.org/integration/autoland/rev/52ab9d52c4ed
Part 5 - Port test_search_suggestions.js. r=mak
https://hg.mozilla.org/integration/autoland/rev/5980851731f7
Part 6 - Port part of search_suggestions_aliases.js. r=mak

Comment 11

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/aeb4b6a030f7
https://hg.mozilla.org/mozilla-central/rev/42402e0a35c5
https://hg.mozilla.org/mozilla-central/rev/27c5961fc195
https://hg.mozilla.org/mozilla-central/rev/c479ea11c586
https://hg.mozilla.org/mozilla-central/rev/52ab9d52c4ed
https://hg.mozilla.org/mozilla-central/rev/5980851731f7