Closed Bug 1623672 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 22334 - Disallow backdrop-filter on the root element.

Categories

(Core :: Web Painting, task, P4)

Product:
Core
Component:
Web Painting
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22334 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22334
Details from upstream follow.

Chris Harrelson <chrishtr@chromium.org> wrote:

Disallow backdrop-filter on the root element.

There is nothing behind the root element stacking context in the same
frame, and it's also important not to blend with any white behind
the root frame.

This is also causing a problem at the moment in Chromium because
to implement the semantics in [1] for filters of the root element group
applying after drawing and before compositing into the root group,
we now paint two PaintChunks for the LayoutView [2]. The second such
PaintChunk has a PropertyTreeState that includes filters (including
at the moment backdrop-filter). But since it's not composited the code
fails to work correctly.

[1] https://drafts.fxtf.org/compositing/#pagebackdrop
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1979258

Bug: 1061802

Change-Id: I9212213d1787647b171fbefcf18ef80d51b74a2b

Reviewed-on: https://chromium-review.googlesource.com/2109318
WPT-Export-Revision: 9e10719a68d0896ffd0a7a5185415ba60e611a4b

Component: web-platform-tests → Web Painting
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/filter-effects/backdrop-filter-root-element.html: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub] (Chrome: FAIL, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d134b5d60e15
[wpt PR 22334] - Disallow backdrop-filter on the root element of the main page., a=testonly
https://hg.mozilla.org/integration/autoland/rev/1230d33aa1ba
[wpt PR 22334] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d134b5d60e15
https://hg.mozilla.org/mozilla-central/rev/1230d33aa1ba

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.