Closed Bug 1623706 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 22339 - [FlexNG] 4/4 Cache intrinsic logical widths instead of preferred.

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22339 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22339
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[FlexNG] 4/4 Cache intrinsic logical widths instead of preferred.

This moves the caching from preferred logical widths "down" one level to
intrinsic logical widths.

This improves performance of FlexNG in particular, but also legacy
flexbox and other functions. This comes at the expense of some grid
perf-tests which seems like the right tradeoff given how popular flex is.
FlexNG: https://pinpoint-dot-chromeperf.appspot.com/job/17dcb4ff620000
non-FlexNG: https://pinpoint-dot-chromeperf.appspot.com/job/161c179b620000

This patch transforms ComputePreferredLogicalWidths into
PreferredLogicalWidths.

We also store what we used to resolve %-block-sizes within the min/max
phase. We can use this additional data for a more precise min/max size
cache see: CanUseCachedIntrinsicLogicalWidths.

Bug: 845235
Change-Id: I4a6584f580ae7967b156592d1e97ddbb4631a432
Reviewed-on: https://chromium-review.googlesource.com/2099322
WPT-Export-Revision: 9a1c33e9298a6c1e35c952f3e54d00d19834b809

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests

Status Summary

Firefox

PASS: 4
FAIL: 2

Chrome

PASS: 2
FAIL: 4

Safari

PASS: 1
FAIL: 5

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-sizing/intrinsic-percent-replaced-dynamic-001.html: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-sizing/intrinsic-percent-replaced-dynamic-005.html: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bd60f7b15782
[wpt PR 22339] - [FlexNG] 4/4 Cache intrinsic logical widths instead of preferred., a=testonly
https://hg.mozilla.org/integration/autoland/rev/cd4e77469af1
[wpt PR 22339] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/bd60f7b15782
https://hg.mozilla.org/mozilla-central/rev/cd4e77469af1

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.