1623817 - Dynamic minimum size of event and task dialogs is broken

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Geoff Lankow (:darktrojan)]

In bug 1480338 I added a check to see if the dialog was too small for its contents and added minwidth/minheight attributes if it was. With bug 1598050, the attributes are now added to the wrong element and consequently not enforced.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1623817-dialog-min-size-again-1.diff

Moved the attributes to the root element again. I've also tested that they are on the outer element, and removed some of the Mozmill-ness of the test.

Comment 2

[Paul Morris [:pmorris]]

Comment on attachment 9134579 [details] [diff] [review]
1623817-dialog-min-size-again-1.diff

Review of attachment 9134579 [details] [diff] [review]:
-----------------------------------------------------------------

Changes look good.  I tested it and it does keep the dialog from shrinking past the minimum size.  Test passes locally.  r+

I noticed something that's happening with or without this patch: resizing the height of the dialog causes some jumping/flickering where between the top menu bar and below the title bar in the dialog you can briefly see through to the window behind before the gap closes up again.

Comment 3

[Paul Morris [:pmorris]]

I've filed bug 1624010 for the flickering issue.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4297a939121c
Fix minimum size check on event/task dialog. r=pmorris

Comment 5

[Geoff Lankow (:darktrojan)]

Oh hell, this test is failing on Mac, which I knew but forgot about. Will fix … uh … soon.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b09bd153c9cd
follow-up - Stop defining dialog min-width with CSS. rs=bustage-fix DONTBUILD

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: 1623817-dialog-min-size-again-css.diff

I'd better have this reviewed despite already landing it. This CSS has been redundant since I originally fixed the bug, only now that the test checks for attributes it's causing a problem. With the CSS in place the dialog never overflows and never gets a min-width attribute.