Closed Bug 1623905 Opened 1 year ago Closed 1 year ago

The CFR button is not minimized when clicking the 'Not Now' option

Categories

(Firefox :: Messaging System, defect, P1)

Product:
Firefox
Component:
Messaging System
Version:
74 Branch
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 76
Iteration:
76.2 - Mar 23 - Apr 5
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox74 --- wontfix
firefox75 --- wontfix
firefox76 --- verified

People

(Reporter: cbaica, Assigned: andreio)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(2 files)

CFR button bug
8.87 MB, video/mp4
Details
Bug 1623905 - The CFR button is not minimized when clicking cancel
47 bytes, text/x-phabricator-request
Details | Review
Attached video CFR button bug —

Affected platforms

  • Windows
  • Ubuntu
  • macOS

Steps to reproduce

  1. Launch Firefox.
  2. Trigger the CFR addon recommandation.
  3. Click the 'Not Now' option displayed on the doorhanger.

Expected result

  • The doorhanger is dismissed and the CFR button is minimized, but still displayed.

Actual result

  • The CFR button is not minimized.

Regression range

  • Last good revision: e1a3a62f20351336f9afbcd3df26996b2acc14ae
  • First bad revision: 532b71703571a8a65e58330208afa0b28febfba8

Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e1a3a62f20351336f9afbcd3df26996b2acc14ae&tochange=532b71703571a8a65e58330208afa0b28febfba8

Additional notes

  • This issue occurs for the CFR pin tab recommandation as well.
Summary: The CFR button is not minimized when click the 'Not Now' option → The CFR button is not minimized when clicking the 'Not Now' option
Has Regression Range: --- → yes
Has STR: --- → yes
Keywords: regression
Blocks: cfr
Iteration: --- → 76.2 - Mar 23 - Apr 5
Priority: -- → P1
Assignee: nobody → andrei.br92

Andrei is this something we'd need to uplift or can it ride the trains?

status-firefox74: --- → wontfix
status-firefox-esr68: --- → unaffected
Flags: needinfo?(andrei.br92)
Version: Trunk → 74 Branch

This can ride the trains.

status-firefox75: affected → wontfix
Flags: needinfo?(andrei.br92)
Pushed by aoprea@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/931d32cf49a9
The CFR button is not minimized when clicking cancel r=k88hudson

https://hg.mozilla.org/mozilla-central/rev/931d32cf49a9

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox76: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (76.0a1 Build ID - 20200402095145) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15.3. Now, the "CFR Recommendation" message is displayed in the minimized form if the "Not Now" button is clicked.

Status: RESOLVED → VERIFIED
status-firefox76: fixed → verified
You need to log in before you can comment on or make changes to this bug.