network.proxy.backup.socks breaks proxy dialog
Categories
(Firefox :: Settings UI, defect)
Tracking
()
People
(Reporter: basinilya, Unassigned)
References
(Regression)
Details
(Keywords: regression)
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:74.0) Gecko/20100101 Firefox/74.0
Steps to reproduce:
In a pretty old Firefox profile on my work PC when I go to settings/network and in the proxy dialog choose manual settings I can't fill in the socks proxy settings: when I start typing the letters disappear instantly.
I had to go to about:settings and reset each and every setting to default until I found that deleting these two actually helps:
network.proxy.backup.socks=""
network.proxy.backup.socks_port=0
I never edited these settings manually before. However I did have Frigate installed in the past.
See this forum topic for additional info:
http://forums.mozillazine.org/viewtopic.php?f=38&t=3060066&p=14860356#p14860356
Actual results:
letters disappear
Expected results:
The remnants of uninstalled addons like network.proxy.backup.socks should not break typing in the proxy dialog.
|
||
Comment 1•5 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
|
||
Updated•5 years ago
|
|
||
Comment 2•5 years ago
|
||
Hm. It looks like we actually set those preferences ourselves here: https://searchfox.org/mozilla-central/rev/7fba7adfcd695343236de0c12e8d384c9b7cd237/browser/components/BrowserGlue.jsm#3411-3418
That was added in bug 969282 - I suspect this is a regression caused by that.
Hey Gijs, I notice that in https://phabricator.services.mozilla.com/D58120, we skip the work of resetting the backup prefs when opening the dialog here: https://searchfox.org/mozilla-central/rev/7fba7adfcd695343236de0c12e8d384c9b7cd237/browser/components/preferences/connection.js#273
But if those preference values are set as per this migration code, then we end up overwriting whatever the user types into the text input with the backed up value here: https://searchfox.org/mozilla-central/rev/7fba7adfcd695343236de0c12e8d384c9b7cd237/browser/components/preferences/connection.js#315-318
Should we even be using backup prefs here? Or should we have cleared them in the migration? It's not clear to me what the right move is here.
|
||
Updated•5 years ago
|
|
||
Comment 3•5 years ago
|
||
(In reply to Mike Conley (:mconley) (:⚙️) from comment #2)
Hm. It looks like we actually set those preferences ourselves here: https://searchfox.org/mozilla-central/rev/7fba7adfcd695343236de0c12e8d384c9b7cd237/browser/components/BrowserGlue.jsm#3411-3418
That was added in bug 969282 - I suspect this is a regression caused by that.
Hey Gijs, I notice that in https://phabricator.services.mozilla.com/D58120, we skip the work of resetting the backup prefs when opening the dialog here: https://searchfox.org/mozilla-central/rev/7fba7adfcd695343236de0c12e8d384c9b7cd237/browser/components/preferences/connection.js#273
But if those preference values are set as per this migration code, then we end up overwriting whatever the user types into the text input with the backed up value here: https://searchfox.org/mozilla-central/rev/7fba7adfcd695343236de0c12e8d384c9b7cd237/browser/components/preferences/connection.js#315-318
Should we even be using backup prefs here? Or should we have cleared them in the migration? It's not clear to me what the right move is here.
I just landed a fix for this in bug 1625773. Sorry. :-(
Description
•