1623938 - HighContrast theme broken in web (config) pages

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Jonathan Michalon]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

When using HighContrast theme, try to use the "account settings" tab.

Actual results:

No hover interaction, and no highlight of current section.

Expected results:

It should look and behave like a normal application setting UI.

This seems to be due to the fact that, now, the "account settings" tab (along with the preferences tab) is a tab instead of a window, and rendered as a web page.
By default, the option to override content's theme with desktop theme is set to do so only for HighContrast, but most probably due to a bug in the toolkit it's not fully translated and breaks a few items.
According to visually impaired people that use HighContrast theme, the default "light" theme provided is OK, so we think it would be wise to set the default setting to never override the default theme at all, with no exception for HighContrast since it's not very usable anyways.

Comment 1

[WaltS48 [:walts48]]

If I understand correctly the reporter doesn't see the selected sections such as "Server Settings", "Copies and Folders" and others highlighted in the Account Setting tab using the operating systems High Contrast theme.

I can reproduce with the Account Settings, Preferences and Add-ons tabs using 75.0b1 and 76.0a1 on Ubuntu 18.04.4 LTS Linux.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1623938 - Disable high-contrast overriding document colors on non-Windows platforms by default. r=morgan

The high-contrast light GTK theme has some known issues. The dark theme works
much better, but we have multiple complaints about high contrast users that
don't know about the "override document colors" setting.

Disable it for now so as to go to the previous state for the time being.

Mac/Android don't have a high-contrast theme either (or we don't hook into it),
so 1 seems like a better / less confusing default.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

The dark theme works much better, but we have multiple complaints about high contrast users that don't know about the "override document colors" setting.

To be clear this report is not the case, obviously, but we got others :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7172c878c66e
Disable high-contrast overriding document colors on non-Windows platforms by default. r=morgan,Jamie

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7172c878c66e

Comment 7

[Mike Kilday]

Can confirm changing that setting fixed my issue. Thanks folks, sorry it was a duplicate.

Comment 8

[Darkspirit]

Should this be uplifted to Beta?

Comment 9

[Darkspirit]

Oh, it is.