Closed Bug 1623983 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 22364 - Re-land: Remove workaround [1] to add a placeholder for lazyload images.

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22364 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22364
Details from upstream follow.

Chris Harrelson <chrishtr@chromium.org> wrote:

Re-land: Remove workaround [1] to add a placeholder for lazyload images.

This is a re-land of [2]. It was reverted due to a flakiness introduce
in [3]. The reason for the flakiness appears to have a couple of sources:
(a) sometimes the image for one of the ref/non-ref will load a bit faster
(b) scrollbars present in the ref case, because the image is not clipped
by overflow:hidden
(c) 8px margin

(a) is fixed by using reftest-wait. (b) is fixed by adding overflow:hidden
to the HTML element; (c) is fixed with margin:0.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1773869
[2] https://chromium-review.googlesource.com/c/chromium/src/+/2103708
[3] external/wpt/html/semantics/embedded-content/the-img-element/image-loading-subpixel-clip.html

Bug: 992765, 999019, 995119, 999209, 1045745

Change-Id: I6ad8c5564f65d131da9b04180499a4bd98a4c8d2
Reviewed-on: https://chromium-review.googlesource.com/2111906
WPT-Export-Revision: 34260c70ef2f6fd22404f8402cc9bfc1aee6d983

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1
FAIL : 1

Chrome

PASS : 1

Safari

TIMEOUT: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/embedded-content/the-img-element/image-loading-subpixel-clip.html: FAIL [Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub] (Chrome: PASS, Safari: TIMEOUT)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b94f7635a515
[wpt PR 22364] - Re-land: Remove workaround [1] to add a placeholder for lazyload images., a=testonly
https://hg.mozilla.org/integration/autoland/rev/6755de0f21ca
[wpt PR 22364] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/b94f7635a515
https://hg.mozilla.org/mozilla-central/rev/6755de0f21ca

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.