1623984 - Disable preview on addons-bloomfilters

Status: RESOLVED FIXED

(Cloud Services :: Operations: Kinto, task)

Description

[Ethan Glasser-Camp (:glasserc)]

In https://bugzilla.mozilla.org/show_bug.cgi?id=1619994, :eviljeff expressed a desire that we disable two-person signoff on this collection. I believe this is considered acceptable because this is server-to-server publishing, as with Normandy, and signoff is done in the other system.

Comment 1

[Mathieu Leplatre [:leplatrem]]

Can we have a formal approval from the security-team here?
Thanks

Comment 2

[Andrew Williamson [:eviljeff]]

Can we have this implemented on stage now, pending approval for security team for production. It's blocking QA so we need it on stage (the kinto dev server configuration is too different to be useful for verifying everything works as expected)

Comment 3

[Julien Vehent]

Add-ons server (AMO) will implement its own layer of two-person signoff for any add-on that has more than 100k users, and allow blocklisting without two-person signoff for add-ons with less users. This has been discussed in https://github.com/mozilla/addons-server/issues/13618 and has received security approval.

Therefore, I also approve of this require to disable two-person signoff on the addons-bloomfilters collection.

Comment 4

[Sven Marnach :sven]

Julien, thanks for the approval!

I will go ahead and implement this now.

Comment 5

[Mathieu Leplatre [:leplatrem]]

Here is an example: https://github.com/mozilla-services/cloudops-deployment/pull/3571/files

And since the preview collection was created, it should be manually deleted once review is disabled. See 1612382

Comment 6

[Sven Marnach :sven]

Config changes are in https://github.com/mozilla-services/cloudops-deployment/pull/3749.

Comment 7

[Sven Marnach :sven]

Review should now be disabled for both prod and stage.