Closed Bug 162400 Opened 22 years ago Closed 22 years ago

crashes in [@ nsMsgDatabase::NotifyKeyAddedAll]

Categories

(MailNews Core :: Database, defect)

x86
Windows 2000
defect
Not set
critical

Tracking

(Not tracked)

VERIFIED DUPLICATE of bug 162513

People

(Reporter: alecf, Assigned: Bienvenu)

Details

(Keywords: crash, topcrash)

Crash Data

I've crashed twice with today's nightly build in nsMsgDatabase::NotifyKeyAddedAll and NotifyKeyChangeAll - a quick look at the code looks like a database listener is being removed as part of notification. Makes me think we should be doing notifications in reverse order, like we do elsewhere (i.e. observer service, etc) Here's one of the stacks: (I had the message after I left the machine idle for a few minutes, though I also got one hitting the "Next" button in the toolbar) nsMsgDatabase::NotifyKeyAddedAll [c:/builds/seamonkey/mozilla/mailnews/db/msgdb/src/nsMsgDatabase.cpp, line 539] nsMsgDatabase::AddNewHdrToDB [c:/builds/seamonkey/mozilla/mailnews/db/msgdb/src/nsMsgDatabase.cpp, line 2751] nsImapMailFolder::NormalEndHeaderParseStream [c:/builds/seamonkey/mozilla/mailnews/imap/src/nsImapMailFolder.cpp, line 2614] XPTC_InvokeByIndex [c:/builds/seamonkey/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp, line 106] EventHandler [c:/builds/seamonkey/mozilla/xpcom/proxy/src/nsProxyEvent.cpp, line 568] PL_HandleEvent [c:/builds/seamonkey/mozilla/xpcom/threads/plevent.c, line 597] PL_ProcessPendingEvents [c:/builds/seamonkey/mozilla/xpcom/threads/plevent.c, line 530] _md_EventReceiverProc [c:/builds/seamonkey/mozilla/xpcom/threads/plevent.c, line 1078] nsAppShellService::Run [c:/builds/seamonkey/mozilla/xpfe/appshell/src/nsAppShellService.cpp, line 452] main1 [c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp, line 1535] main [c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp, line 1886] WinMain [c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp, line 1904] WinMainCRTStartup() KERNEL32.DLL + 0x1ca90 (0x77e9ca90)
argh, I just crashed again.. that's 4 times this build.. raising severity oh, this is build 2002-08-12-09-trunk
Severity: normal → critical
I haven't seen this, but my build wasn't completely up to date. I'll see if I can reproduce it now that I've pulled the latest changes.
Alec, what code are you seeing removing notifications? nothing in that stack trace should remove notifications that I can think of.
I'm going to recommend pulling the next nightly build - this smells like a dependency problem, i.e., a corrupt build. The other possibility is that you're doing something you haven't thought to mention - have you had this happen in the debugger?
no this was a nightly binary download - no symbols, no debugger - talkback is all we got my only theory was the listener list, because GetElementAt() would return null if a listener was removed while iterating through this list. I don't have the code to justify it :) also, note that some of the time it was biff firing
this works fine for me - I don't see any crashes. And, that code hasn't been changed in a while, afaik. I'd try tomorrow's build.
QA Contact: gayatri → stephend
I'm going to dup this, since the other bug has a potential msg that might somehow cause this problem (not that it did for me :-( ) *** This bug has been marked as a duplicate of 162513 ***
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → DUPLICATE
verified dup
Status: RESOLVED → VERIFIED
Keywords: crash, topcrash
Summary: crashes in nsMsgDatabase::NotifyKey* → crashes in [@ nsMsgDatabase::NotifyKeyAddedAll]
my changes gave a way for talkback to track data.
Product: MailNews → Core
Product: Core → MailNews Core
Crash Signature: [@ nsMsgDatabase::NotifyKeyAddedAll]
You need to log in before you can comment on or make changes to this bug.