"mach puppeteer-test --write-results" adds white-space after closing brackets
Categories
(Remote Protocol :: Agent, defect, P3)
Tracking
(firefox76 fixed)
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: whimboo, Assigned: jgraham)
References
Details
Attachments
(3 files)
I was using mach puppeteer-test --write-results today to update the file puppeteer-expected.json file. Checking the diff I can see a lot of additionally added blanks after each closing bracket:
- ],
+ ],
"Firefox Browser Page Frame.waitForSelector should work with removed MutationObserver": [
"FAIL"
James is that a regression? The currently checked-in version doesn't have those blanks.
|
Reporter | |
Comment 1•4 years ago
|
||
Also tests are written in different orders to that file which makes diff basically useless. :/ Is it expected that we write the exact order of tests as run by Puppeteer?
|
Assignee | |
Comment 2•4 years ago
|
||
The whitespace comes from Python. To make the order consistent we're going to need to either change the data structure to a list or otherwise use an ordereddict or something to ensure that things get written in the right order.
|
|
Assignee | |
Comment 3•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 4•4 years ago
|
||
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/autoland/rev/ab2525a1da3b Fix the ordering of puppeteer expected data, r=remote-protocol-reviewers,maja_zf https://hg.mozilla.org/integration/autoland/rev/dbabf2e388fa Always write results with --write-results, r=remote-protocol-reviewers,maja_zf
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ab2525a1da3b
https://hg.mozilla.org/mozilla-central/rev/dbabf2e388fa
|
|
Reporter | |
Comment 7•4 years ago
|
||
Oh, we should have updated the puppeteer-expected.json file when these patches landed. I will do it via bug 1607560 now.
|
|
Reporter | |
Comment 8•4 years ago
|
||
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 9•4 years ago
•
|
||
It's insertion order, not alphabetical.
|
|
||
Updated•4 years ago
|
|
||
Comment 10•4 years ago
|
||
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1bac37288ded [remote] Update puppeteer-expected.json for insertion order. r=remote-protocol-reviewers,jgraham
|
||
Comment 11•4 years ago
|
||
| bugherder | ||
Description
•