Closed Bug 1624047 Opened 4 months ago Closed 4 months ago

Default browser agent not being packaged

Categories

(Toolkit :: General, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox75 --- fixed
firefox76 --- fixed

People

(Reporter: mhowell, Assigned: mhowell)

Details

Attachments

(1 file)

My last-second fix for the diffoscope failure that caused bug 1602463 to initially be backed out inadvertently hid the real problem by keeping the agent from ever being packaged at all, because it didn't occur to me that build CONFIG values don't get automatically translated into preprocessor defines, so the one that I added a check for is never set there.

I have a patch which fixes that and also actually fixes the packaging problem that diffoscope found (which is that default-browser-agent.exe was ending up in the ARM64 package's i686 EME build directory).

Pushed by mhowell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dd4b53e80177
Fix default browser agent packaging. r=bytesized

Comment on attachment 9134834 [details]
Bug 1624047 - Fix default browser agent packaging. r=bytesized

Beta/Release Uplift Approval Request

  • User impact if declined: I know the request there is still pending, but this is an important fix to bug 1602463, so it will need to uplifted if (and only if) that bug is. The patch itself also depends on bug 1602463.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1602463
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is just a small packaging fix which I've verified on try (see the Phabricator revision).
  • String changes made/needed:
Attachment #9134834 - Flags: approval-mozilla-beta?
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76

Comment on attachment 9134834 [details]
Bug 1624047 - Fix default browser agent packaging. r=bytesized

approved for 75.0b9

Attachment #9134834 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.