Closed
Bug 1624056
Opened 4 years ago
Closed 4 years ago
Properly vendor mp4parse-rust and update mp4parse-rust to 0dc3e6e
Categories
(Core :: Audio/Video: Playback, enhancement, P2)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla78
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: jbauman, Assigned: jbauman)
References
Details
Attachments
(1 file)
As one of the oldest pieces of rust code in our tree, mp4parse-rust currently relies on the update-rust.sh script to pull updates from the github repo. This is inconsistent with the standard vendoring approach used for rust code in mozilla-central, and should be updated.
|
Assignee | |
Updated•4 years ago
|
Assignee: nobody → jbauman
|
|
Assignee | |
Updated•4 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 1•4 years ago
|
||
This requires --build-peers-said-large-imports-were-ok since
third_party/rust/mp4parse/src/lib.rs is 113KB. This code is just moving from
media/mp4parse-rust to third_party/rust, so it's not really adding to net code
size.
|
||
Updated•4 years ago
|
Attachment #9146931 -
Attachment description: Bug 1624056 - Properly vendor mp4parse-rust. r=kinetik → Bug 1624056 - Properly vendor mp4parse-rust. r=kinetik,#build
|
|
Assignee | |
Updated•4 years ago
|
See Also: → 1635960
Summary: Properly vendor mp4parse-rust → Properly vendor mp4parse-rust and update mp4parse-rust to 0dc3e6e
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0b00e6f0d4a0 Properly vendor mp4parse-rust. r=kinetik
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in
before you can comment on or make changes to this bug.
Description
•