Closed Bug 1624071 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 22375 - Remove broken icon rendering for loading="lazy" images while loading

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22375 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22375
Details from upstream follow.

Chris Harrelson <chrishtr@chromium.org> wrote:

Remove broken icon rendering for loading="lazy" images while loading

Non-lazy images don't show this icon. It's incorrect to show such
an icon just because an image is loading. In addition, it messes
up the intrinsic sizing heuristics for aspect ratio.

Both lazy and non-lazy images still show a broken image icon when
images fail to load via HTTP failure.

Bug: 997606, 1045745

Change-Id: I5dc6bac50a1c43395057e37547864e9e3fc13b6d

Reviewed-on: https://chromium-review.googlesource.com/2109330
WPT-Export-Revision: b5435a3afbd1d51e834f936954233808177d858e

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 1[Gecko-windows10-64-opt] 2[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub]
FAIL: 1

Chrome

PASS: 2

Safari

PASS: 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html: FAIL [Gecko-windows10-64-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub] (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2ca218966a4a [wpt PR 22375] - Remove broken icon rendering for loading="lazy" images while loading, a=testonly https://hg.mozilla.org/integration/autoland/rev/15dfb3988f07 [wpt PR 22375] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.