Closed
Bug 1624129
Opened 5 years ago
Closed 5 years ago
[fts] generate_table.py is not Python 3 compatible
Categories
(Thunderbird :: Search, task)
Thunderbird
Search
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 76.0
People
(Reporter: rjl, Assigned: rjl)
References
Details
Attachments
(1 file)
9.80 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
File is comm/mailnews/extensions/fts3/data/generate_table.py, and it's used to generate comm/mailnews/extensions/fts3/src/Normalize.c. The latter is stored in-tree so it's not as though generate_tables.py runs every time.
Assignee | ||
Comment 1•5 years ago
|
||
This is a direct port of the existing code to Python 3.
This was done in multiple steps:
- Fix the mixed tabs/spaces. Use 4 spaces for indentation per
current standards.
- Run through 2to3.py.
- Fix mozlint errors.
- Verify output of current script matches the Python 3 output.
The output does not match the copy of Normalize.c in ../src as
that file got caught up in the recent mass clang formatting.
Attachment #9134894 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → rob
Status: NEW → ASSIGNED
Updated•5 years ago
|
Attachment #9134894 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed-tb
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/2bf83584b702
Make generate_table.py python 3 compatible. r=mkmelin
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 76.0
You need to log in
before you can comment on or make changes to this bug.
Description
•