Closed Bug 1624129 Opened 5 months ago Closed 4 months ago

[fts] generate_table.py is not Python 3 compatible

Categories

(Thunderbird :: Search, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 76.0

People

(Reporter: rjl, Assigned: rjl)

References

Details

Attachments

(1 file)

File is comm/mailnews/extensions/fts3/data/generate_table.py, and it's used to generate comm/mailnews/extensions/fts3/src/Normalize.c. The latter is stored in-tree so it's not as though generate_tables.py runs every time.

This is a direct port of the existing code to Python 3.
This was done in multiple steps:
- Fix the mixed tabs/spaces. Use 4 spaces for indentation per
  current standards.
- Run through 2to3.py.
- Fix mozlint errors.
- Verify output of current script matches the Python 3 output.

The output does not match the copy of Normalize.c in ../src as
that file got caught up in the recent mass clang formatting.
Attachment #9134894 - Flags: review?(mkmelin+mozilla)
Assignee: nobody → rob
Status: NEW → ASSIGNED
Attachment #9134894 - Flags: review?(mkmelin+mozilla) → review+
Blocks: 1624429

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/2bf83584b702
Make generate_table.py python 3 compatible. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 76.0
You need to log in before you can comment on or make changes to this bug.