1624155 - Extensions stop working when interacting with popup while first party isolation is enabled

Status: RESOLVED FIXED

(WebExtensions :: Compatibility, defect)

Description

[forte007]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:74.0) Gecko/20100101 Firefox/74.0

Steps to reproduce:

Install newest Firefox (74.0) or Firefox Nightly 76.0a1 (2020-03-21), enable privacy.firstparty.isolate, install uBlock Origin and Bitwarden (no need to login).

Go to a website which triggers a browser action popup (example: Disqus comments, PayPal login form). For testing purposes, go to http://www.popuptest.com/goodpopups.html and click on the first link or the third to open a popup. Focus the popup, then interact with Bitwarden via the vault hotkey CTRL+SHIFT+Y or alternatively, open the context menu via right-click -> Bitwarden -> Auto-fill -> Vault is locked (click on it).

Actual results:

Most if not all extensions will ceise to work or be able to access the pages. Clicking on uBlock will show several question marks on the stats, indicating the error. You can also check non-working adblocking capability by going to https://blockads.fivefilters.org/

Expected results:

At least all other extensions should still continue to work.

Comment 1

[forte007]

This issue is not happening in 68.6.0esr.

Also, it does not matter whether "Run in Private Windows" is enabled for both extensions.

A browser restart or disabling and enabling all extensions will fix the issue, until you interact with the popup again.

If you have the extension console open from about:debugging and click on the "Vault is locked" button to trigger this issue, the following error comes up: "Error: Debug target was disconnected" for all extensions. After trying to open the console again, it says: "Error: unknownError"

I don't know what Bitwarden does to trigger this issue, and I guess its not the only addon that causes it, but it is extremely annoying when you just want to pay for your order with PayPal or login with a third party account; while having FPI enabled.

Bitwarden has a Github issue marginally related to this, but no real discussion is going on: https://github.com/bitwarden/browser/issues/859

They say its related to chrome.extension.getBackgroundPage() returning null for non-private mode browserAction popup windows. My layman's guess is that when FPI is enabled, this somehow botches the entire API for all tabs.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Andrei Purice]

Hello,

I was able to reproduce this on all versions of Firefox Nightly 76.0a1 (2020-03-25), beta 75.0b8 and release 74.0.

I will add a component for this issue in order to get the dev team involved.
If you feel like the component is not the right one please change it to a more appropriate one.

Comment 4

[forte007]

(In reply to Andrei Purice from comment #3)

Hello,

I was able to reproduce this on all versions of Firefox Nightly 76.0a1 (2020-03-25), beta 75.0b8 and release 74.0.

I will add a component for this issue in order to get the dev team involved.
If you feel like the component is not the right one please change it to a more appropriate one.

Thank you for confirming the issue. Will you still add the component?

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:mixedpuppy, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:mixedpuppy, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 7

[Rob Wu [:robwu]]

Works fine on Nightly 77, still broken on Beta.
I did a bisect with mozregression and the issue seems to have been fixed with bug 1616353.