Closed Bug 1624191 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 22383 - Explicitly set min connector overlap for radical fonts

Categories

(Core :: MathML, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22383 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22383
Details from upstream follow.

Frédéric Wang <fwang@igalia.com> wrote:

Explicitly set min connector overlap for radical fonts

Currently, this value is calculated automatically from font metrics [1]
that are generally only set explicitly in mathfont.py's save() function.
All scripts generating fonts with verticalComponents or horizontalComponents
set this value except radicals.py, so that latter case is handled in this
commit. The corresponding fonts are only used in root-parameters-1.html
and min connector overlap is actually not important for this test.
This commit also adds comments describring the expected tuples for
verticalComponents and horizontalComponents for better readability.

[1] https://github.com/fontforge/fontforge/blob/c6d02ad068b578eea747f62fad6f369e9ad681ab/fontforge/mathconstants.c#L188

Component: web-platform-tests → MathML
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 47 tests

Status Summary

Firefox

OK : 1
PASS: 7[GitHub] 53[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]

Chrome

OK : 1
FAIL: 7

Safari

OK : 1
PASS: 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b14e196b23b7
[wpt PR 22383] - Explicitly set min connector overlap for radical fonts, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.