1624216 - URL hover popup on the bottom left of screen doesnt disappear (doesnt invalidate properly)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Mayank Bansal]

Attachment: bandicam 2020-03-22 23-44-12-900.mp4

1. Import the bookmark file attached.
2. Hover mouse over the first bookmark"core bug list" . A popup in the bottom-left of screen appears showing the actual URL. Keep your mouse over the bookmark for a few seconds
3. Move your mouse to hover over the second bookmark "autoland:Shortlog". This is a much shorter URL

ER: The first, longer popup should disappear/invalidate, and the second shorter popup should appear

AR: Parts of the longer bookmark are visible on the screen.

Comment 1

[Mayank Bansal]

Doesnt happpen if I set
gfx.webrender.max-partial-present-rects to 0

Comment 2

[Mayank Bansal]

Attachment: bookmarks.html

Comment 3

[Mayank Bansal]

Attachment: Application Basics ------------------ Name: Firefox Version: 76.0a1 Build ID: 20200322093956 Update Channel: nightly User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0 OS: Windows_NT 10.0 Launcher Process: Enabled

Comment 4

[Mayank Bansal]

Attachment: about:support

Comment 5

[Mayank Bansal]

actually, you dont even need my bookmarks. On any bugzilla page, hover on "My dashboard", and then on "New bug" . Same glitch will appear.

Comment 6

[Darkspirit]

I don't see this bug with Radeon RX480 on Win10 1909. (2560x1440)

Comment 7

[Sotaro Ikeda [:sotaro]]

Thanks for reporting. I confirmed the problem. I am going to look into it.

Comment 8

[Sotaro Ikeda [:sotaro]]

When the problem happened like STRs of bug 1624216 comment 0 and and Bug 1624338 comment 0, related ui seemed to be rendered as different picture cache. when pref gfx.webrender.debug.picture-caching=true, they were rendered as different color. If the picture cache size or position was changed dynamically, dirty rect seems not work well.

:gw, do you know when ui element is rendered as a different picture cache?

Comment 9

[Glenn Watson [:gw]]

It can occur when we have disjoint picture tiles in a slice, where we try to reduce the size of the rect area that we consider valid.

Could you try with setting dirty_rects_are_valid to false when we invalidate at [1] and see if that fixes the problem? If not, I'll try to take a look at this tomorrow (feel free to disable partial present in the meantime if it's a major issue).

[1] https://searchfox.org/mozilla-central/rev/4d9cd186767978a99dafe77eb536a9525980e118/gfx/wr/webrender/src/picture.rs#982

Comment 10

[Sotaro Ikeda [:sotaro]]

(In reply to Glenn Watson [:gw] from comment #9)

It can occur when we have disjoint picture tiles in a slice, where we try to reduce the size of the rect area that we consider valid.

Could you try with setting dirty_rects_are_valid to false when we invalidate at [1] and see if that fixes the problem? If not, I'll try to take a look at this tomorrow (feel free to disable partial present in the meantime if it's a major issue).

Thanks. I am going to try it today.

Comment 11

[Sotaro Ikeda [:sotaro]]

It seems to address the problem for me! I am going to test it more. Thank you!

Comment 12

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1624216 - Dirty rect is not valid when Tile's local valid rect is changed

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08ad6f3a8a55
Dirty rect is not valid when Tile's local valid rect is changed r=gw

Comment 14

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/08ad6f3a8a55