Closed Bug 1624216 Opened 5 months ago Closed 5 months ago

URL hover popup on the bottom left of screen doesnt disappear (doesnt invalidate properly)

Categories

(Core :: Graphics: WebRender, defect)

x86_64
Windows 10
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox-esr68 --- unaffected
firefox74 --- unaffected
firefox75 --- unaffected
firefox76 + fixed

People

(Reporter: mayankleoboy1, Assigned: sotaro)

References

(Regression)

Details

(Keywords: nightly-community, regression)

Attachments

(4 files, 1 obsolete file)

  1. Import the bookmark file attached.
  2. Hover mouse over the first bookmark"core bug list" . A popup in the bottom-left of screen appears showing the actual URL. Keep your mouse over the bookmark for a few seconds
  3. Move your mouse to hover over the second bookmark "autoland:Shortlog". This is a much shorter URL

ER: The first, longer popup should disappear/invalidate, and the second shorter popup should appear

AR: Parts of the longer bookmark are visible on the screen.

Doesnt happpen if I set
gfx.webrender.max-partial-present-rects to 0

Regressed by: 1593179
Attached file bookmarks.html
Attachment #9134971 - Attachment description:
Attachment #9134971 - Attachment is obsolete: true
Attached file about:support

actually, you dont even need my bookmarks. On any bugzilla page, hover on "My dashboard", and then on "New bug" . Same glitch will appear.

I don't see this bug with Radeon RX480 on Win10 1909. (2560x1440)

OS: Unspecified → Windows 10
Hardware: Unspecified → x86_64
Summary: URL hover popup on the bottom left of screen doesnt disappear (doesnt invalidate properly) → URL hover popup on the bottom left of screen doesnt disappear (doesnt invalidate properly) - Intel HD Graphics 5500

Thanks for reporting. I confirmed the problem. I am going to look into it.

Assignee: nobody → sotaro.ikeda.g
Summary: URL hover popup on the bottom left of screen doesnt disappear (doesnt invalidate properly) - Intel HD Graphics 5500 → URL hover popup on the bottom left of screen doesnt disappear (doesnt invalidate properly)
See Also: → 1624338

When the problem happened like STRs of bug 1624216 comment 0 and and Bug 1624338 comment 0, related ui seemed to be rendered as different picture cache. when pref gfx.webrender.debug.picture-caching=true, they were rendered as different color. If the picture cache size or position was changed dynamically, dirty rect seems not work well.

:gw, do you know when ui element is rendered as a different picture cache?

Flags: needinfo?(gwatson)

It can occur when we have disjoint picture tiles in a slice, where we try to reduce the size of the rect area that we consider valid.

Could you try with setting dirty_rects_are_valid to false when we invalidate at [1] and see if that fixes the problem? If not, I'll try to take a look at this tomorrow (feel free to disable partial present in the meantime if it's a major issue).

[1] https://searchfox.org/mozilla-central/rev/4d9cd186767978a99dafe77eb536a9525980e118/gfx/wr/webrender/src/picture.rs#982

Flags: needinfo?(gwatson) → needinfo?(sotaro.ikeda.g)

(In reply to Glenn Watson [:gw] from comment #9)

It can occur when we have disjoint picture tiles in a slice, where we try to reduce the size of the rect area that we consider valid.

Could you try with setting dirty_rects_are_valid to false when we invalidate at [1] and see if that fixes the problem? If not, I'll try to take a look at this tomorrow (feel free to disable partial present in the meantime if it's a major issue).

Thanks. I am going to try it today.

It seems to address the problem for me! I am going to test it more. Thank you!

Flags: needinfo?(sotaro.ikeda.g)
Pushed by sikeda.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/08ad6f3a8a55
Dirty rect is not valid when Tile's local valid rect is changed r=gw
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
QA Whiteboard: [qa-76b-p2]
You need to log in before you can comment on or make changes to this bug.