dom/html/TextTrackManager.cpp: do not use 'else' after 'return'
Categories
(Developer Infrastructure :: Source Code Analysis, task)
Tracking
(firefox77 fixed)
Tracking | Status | |
---|---|---|
firefox77 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: jacksonsd, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
Filling as a good first bug to learn workflows.
if (aOne->mTime < aTwo->mTime) {
return true;
} else if (aOne->mTime > aTwo->mTime) {
return false;
}
do not use 'else' after 'return'
https://searchfox.org/mozilla-central/source/dom/html/TextTrackManager.cpp#499-501
There are other occurrences of this in the same method:
https://searchfox.org/mozilla-central/source/dom/html/TextTrackManager.cpp#515-518
https://searchfox.org/mozilla-central/source/dom/html/TextTrackManager.cpp#527-536
https://searchfox.org/mozilla-central/source/dom/html/TextTrackManager.cpp#543-547
They should probably fixed at the same time
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
Updated•5 years ago
|
Comment 3•5 years ago
|
||
bugherder |
Updated•2 years ago
|
Description
•