1624236 - js/src/vm/Shape.cpp: do not use 'else' after 'break'

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

    } else {
      uint32_t slot = obj->lastProperty()->slot();
      if (slot < slotSpan) {
        break;
      }

do not use 'else' after 'break'

https://searchfox.org/mozilla-central/source/js/src/vm/Shape.cpp#1429-1434

As the change is easy, it is mostly to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[squidney]

Attachment: Bug 1624236 - 1624236: Removed 'else after 'break' in js/src/vm/Shape.cpp r=Sylvestre

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c79992b340e
1624236: Removed 'else after 'break' in js/src/vm/Shape.cpp r=jandem

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/0c79992b340e