1624246 - Also show "Edit Settings..." for non-Custom presets

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

In the profiler popup, only the "Custom" shows the "Edit Settings..." link.

I think it would be useful to always show "Edit Settings...", so that the user can pick a preset, explore exactly what it contains, and optionally make tweaks (turning the selection into "Custom").

(It seems that selecting one preset and then selecting "Custom" keeps that preset settings and allows editing them, but it's not obvious that it's the case, and it's more clicks!)

Now, "Edit Settings..." from a non-Custom preset could give the wrong impression that the user can actually change that preset. In which case maybe the link could instead say "Customize Setting...", or something else?

Comment 1

[:Harald Kirschner :digitarald]

fwiw, I had the same thought that not only custom shows an edit option. Not sure if there are other ways we can expose that better.

Comment 2

[Julien Wajsberg [:julienw]]

This was also part of my review. Greg said he would ask Victoria.

Comment 3

[Julien Wajsberg [:julienw]]

Greg told me recently he wouldn't like seeing this in the normal popup but would be OK adding it to the "remote debugging embedded popup".

hey Greg, pinging you just so that you can own this and bring it to Victoria :-)

Comment 4

[Greg Tatum [:gregtatum]]

Thinking about this more, I guess it's not too crazy add the link everywhere. I'll add a point to the UX meeting.

Comment 5

[Greg Tatum [:gregtatum]]

Yeah, let's take this one on. 👍

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

I've been annoyed one too many times! Working on it...

Comment 7

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1624246 - Always show "Edit Settings..." in profiler popup and devtools panel - r?julienw

The "Edit Settings..." link opens about:profiling. It was only shown in the profiler popup when the preset was "Custom", forcing the user to select "Custom" before being able to easily tailer settings in about:profiling.
Now that link is always there, so it's possible to quickly jump to about:profiling, including after selecting a preset than can then be customized.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f95ea3e3d48
Always show "Edit Settings..." in profiler popup and devtools panel - r=julienw

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0f95ea3e3d48