1624300 - Search Tips/Interventions buttons are not visible in High Contrast mode (Windows)

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Adrian Florinescu [:aflorinescu]]

Attachment: high contrast.jpg

[Environment:]

tested on:

• affected: Windows 10, Windows 7 Pro
• not affected: Mac 10.13, Mac 10.15.2, Ubuntu 18.04

with:

• 75.0b7 20200322132212
• 76.0a1 20200323092419

[Steps to reproduce:]

1. Set Windows high contrast on (any of the high contrast profiles will do)
2. Launch Firefox (new profile)
3. Open Addressbar and type update firefox

[Actual result:]

Intervention is displyed.
The buttons for the Intervention/Tips are not visible in Windows high contrast modes.

[Expected result:]

Intervention is displyed.
The buttons for the Intervention/Tips are visible in Windows high contrast modes.

[Note:]

1. IMO, possibly the same root cause as bug 1623944.
2. This bug lists the STR for Interventions; for STR to trigger Search Tips, see https://bugzilla.mozilla.org/show_bug.cgi?id=1623944#c0

Comment 1

[Mike de Boer [:mikedeboer]]

Dão, could you take a look at this please? Thanks!

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1624300 - Adjust Search Tip/Intervention button styling for non-default Windows themes. r=harry

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa8468f4196f
Adjust Search Tip/Intervention button styling for non-default Windows themes. r=harry

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/fa8468f4196f

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 6

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this issue using 76.0a1 (2020-03-23), on Winwos 10 x64, I can confirm this issue is fixed on the latest nightly. I verified using Fx 76.0a1 (2020-03-31).