1624322 - Don't close the input stream when muting when using mic and headphones on the same device

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Paul Adenot (:padenot)]

This has a lot of side effects:

• Changing the latency (this we can fix differently but we could fix it here)
• Change the bluetooth mode (handsfree -> a2pd, which is very very bad for voip)
• Does an audible glitch because we close and re-open the stream

Comment 1

[Byron Campen [:bwc]]

Is this a playback/MTG bug, or a webrtc one?

Comment 2

[Paul Adenot (:padenot)]

This is related to audio input, so in general it goes in this component.

Comment 3

[Byron Campen [:bwc]]

Ok, so a capture bug, got it. Since we're focusing a lot on quality-of-life and bugfixing right now, should this be P2?

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Glitches affect quality so I'd vote for P2

Comment 5

[Paul Adenot (:padenot)]

This is P1 I'm addressing it now.

Comment 6

[Paul Adenot (:padenot)]

Attachment: Bug 1624322 - Add the raw group ID to MediaDevice. r?jib

Comment 7

[Paul Adenot (:padenot)]

Attachment: Bug 1624322 - Add a method to get the default device for a side in CubebDeviceEnumerator. r?achronop

Comment 8

[Paul Adenot (:padenot)]

Attachment: Bug 1624322 - When muting an input device, don't turn it off if the output is also being used. r?jib

Comment 9

[Paul Adenot (:padenot)]

This needs bug 1624689 before working well.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ce0a5921f1c
Add the raw group ID to MediaDevice. r=jib
https://hg.mozilla.org/integration/autoland/rev/f6dcb0ce3a5e
Add a method to get the default device for a side in CubebDeviceEnumerator. r=achronop
https://hg.mozilla.org/integration/autoland/rev/bafcf7076dc0
When muting an input device, don't turn it off if the output is also being used. r=jib

Comment 11

[Alexandru Michis [:malexandru]]

Backed out 3 changesets for causing bustages in media/MediaManager.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/2fafcff21562bdb011f1b7743895cc1fee24ac3e

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=2fafcff21562bdb011f1b7743895cc1fee24ac3e&fromchange=bafcf7076dc0a3c4576c7b5b45b32eabba02c4a8&selectedJob=295066489

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295066489&repo=autoland&lineNumber=65966

Comment 12

[Paul Adenot (:padenot)]

Somehow missing include that is being included on other platforms.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98f0dd0b45cf
Add the raw group ID to MediaDevice. r=jib
https://hg.mozilla.org/integration/autoland/rev/ff31e658891e
Add a method to get the default device for a side in CubebDeviceEnumerator. r=achronop
https://hg.mozilla.org/integration/autoland/rev/29deade8f415
When muting an input device, don't turn it off if the output is also being used. r=jib

Comment 14

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/98f0dd0b45cf
https://hg.mozilla.org/mozilla-central/rev/ff31e658891e
https://hg.mozilla.org/mozilla-central/rev/29deade8f415