Closed Bug 1624447 Opened 5 months ago Closed 5 months ago

Remove unnecessary msgReadSMIMEOverlay.css

Categories

(MailNews Core :: Security: S/MIME, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 76.0

People

(Reporter: KaiE, Assigned: KaiE)

Details

Attachments

(1 file, 1 obsolete file)

In the past, we had status bar icons for message encryption and signature status, but they were removed at some point. File msgReadSMIMEOverlay.css has leftover rules for elements signed-status and encrypted-status which we no longer have.

We can remove file msgReadSMIMEOverlay.css

(The rules for the icons shown in the message header area are defined in msgHdrViewSMIMEOverlay.css)

Attached patch 1624447-v1.patch (obsolete) — Splinter Review
Assignee: nobody → kaie
Attachment #9135251 - Flags: review?(alessandro)
Comment on attachment 9135251 [details] [diff] [review]
1624447-v1.patch

Review of attachment 9135251 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks for the clean up.
Before I give an r+, could you add a commit message?
Also, it looks like all the PNG icons in those files are not used anymore, can we remove them as well?
Attachment #9135251 - Flags: review?(alessandro) → feedback+

(In reply to Alessandro Castellani (:aleca) from comment #2)

Also, it looks like all the PNG icons in those files are not used anymore,
can we remove them as well?

Two of the icons are still used by smime-compose.css
sbSignOk
sbCryptoOk

You're right that some of the icons can be removed:
sbSignUnknown
sbSignNotOk
sbCryptoNotOk

I'll make a new patch.

Attachment #9135251 - Attachment is obsolete: true

Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/07d338a8bb44
Remove unnecessary msgReadSMIMEOverlay.css and some icons. r=aleca DONTBUILD

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 76.0
You need to log in before you can comment on or make changes to this bug.