Closed Bug 1624448 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 22405 - Fix error handling when calling replace/replaceSync on a non-constructed sheet.

Categories

(Core :: DOM: CSS Object Model, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22405 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22405
Details from upstream follow.

Emilio Cobos Álvarez <emilio@chromium.org> wrote:

Fix error handling when calling replace/replaceSync on a non-constructed sheet.

See https://github.com/WICG/construct-stylesheets/issues/62 for the rejected
promise bit. On top of that we were not returning so we were incorrectly
applying the styles.

Bug: 1063809
Change-Id: I63aa937f66871e3b8eee577a7f2ddd873f45d2c3
Reviewed-on: https://chromium-review.googlesource.com/2116092
WPT-Export-Revision: 2417e1e10b880298c339f41cea2a06e0e2d4e700

Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/cssom/CSSStyleSheet-constructable-replace-on-regular-sheet.html
replace / replaceSync on non-constructed stylesheet: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/403b7beab101
[wpt PR 22405] - Fix error handling when calling replace/replaceSync on a non-constructed sheet., a=testonly
https://hg.mozilla.org/integration/autoland/rev/31fa3685f21b
[wpt PR 22405] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.