Closed Bug 1624450 Opened 6 years ago Closed 6 years ago

Update security/moz.build for NSS PKCS11 v3.0

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox77 fixed)

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: kjacobs, Assigned: kjacobs)

Details

Attachments

(1 file)

Bug 1603628 changes the way NSS handles the fork check defines:

Previously NO_FORK_CHECK was off by default, and Android builds specify the check method as CHECK_FORK_GETPID in security/moz.build.

Now, NO_FORK_CHECK is on by default, and the CHECK_FORK_GETPID definition has no effect unless DO_FORK_CHECK is also defined.

If the Android fork check is no longer required, let's remove it from moz.build. Otherwise we need to append the new define.

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:kjacobs, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(kjacobs.bugzilla)
Pushed by ncsoregi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/730096415ffc Remove CHECK_FORK_GETPID from Android NSS compilation r=glandium
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Flags: needinfo?(kjacobs.bugzilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: