1624488 - Scope dropmarker.css to dropmarker custom element

Status: RESOLVED FIXED

(Toolkit :: Themes, task, P3)

Description

[Tim Nguyen :ntim]

This is an easy one. It's already using shadow parts and shadow DOM. It's just a matter of moving the stylesheet inside the shadow DOM.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1624488 - Scope dropmarker.css to dropmarker custom element.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ce9b251c321
Scope dropmarker.css to dropmarker custom element. r=dao

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out changeset bc failures on ServoStyleSet.cpp.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=9ce9b251c32197db306d1dd2080577769b63e12b&selectedJob=295383265

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=295383265&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/4ba3f4a39170e1625509b553ff60b2bd1bdaf2de

Comment 4

[Tim Nguyen :ntim]

Bug 1625991 should fix the assertion failure.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6c0b1afc2b0
Scope dropmarker.css to dropmarker custom element. r=dao

Comment 6

[Tim Nguyen :ntim]

Seems like the same failure is happening even with bug 1625991. Emilio, do you know what's going on ?

Comment 7

[Dorel Luca [:dluca]]

Backed out changeset a6c0b1afc2b0 (bug 1624488) for browser-chrome failures in checkouts/gecko/layout/style/ServoStyleSet.cpp. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295407510&repo=autoland&lineNumber=6831

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=a6c0b1afc2b004c7ceb92744b48a9c247cd40fa7

Backout:
https://hg.mozilla.org/integration/autoland/rev/d9395310fafca64a3c5ff03f63f118b17ab1fab2

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea3d100c8428
Scope dropmarker.css to dropmarker custom element. r=dao

Comment 9

[Stefan Hindli [:stefan_hindli]]

Backed out changeset ea3d100c8428 (Bug 1624488) as per :emilio's request on Riot for being related to Bug 1626198 CLOSED TREE

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bdd6b5b1d4f
Backed out changeset ea3d100c8428 as per emilio's request on Riot for being related to Bug 1626198 CLOSED TREE

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62f3a2ade7d5
Scope dropmarker.css to dropmarker custom element. r=dao

Comment 12

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/62f3a2ade7d5