1624531 - Selected text changes selection when switching to multi-line editor mode

Status: VERIFIED FIXED

(DevTools :: Console, defect, P3)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: selection_devtools.mkv

Affected versions

• 76.0a1 (20200323092419)
• 75.0b7 (20200322132212)
• 74.0 (20200309095159)

Affected platforms

• Windows 10 x64
• Ubuntu 18.04
• macOS 10.15

Steps to reproduce

1. Open Firefox and Web Console.
2. Paste a large expression (e.g: ` Spans with 'e': `+ Array.from(document.querySelectorAll("span")) .map(el => el.textContent) .filter(s => s.includes("e")) .join(" ").
3. Select the expression (Ctrl+ A).
4. Switch to multi-line editor mode and observe the selected text.
5. Switch back to in line mode and observe the selected text.

Expected result

• At step 4 and step 5, all text remains selected as expected.

Actual result

• At step 4 the selection of the text is moved (not all text is selected as expected).
• At step 5 the selection of the text remains like in multi-line editor mode (not all text is selected as expected).

Regression Range

• Reproduced with 73.01 (20200217142647) as well. I will search for one ASAP if there is one.

Notes

• Attached a screen recording with the issue.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Looks like the same issue as Bug 1622783. Let's see if this is fixed when we land it.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 3

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attaching the pushlog when returning to in line editor mode the selected text remains all selected as expected (step5).
Last good revision: af62dfeb5c0eeb6e5bf5a8626f2556f3fa0d7cd2
First bad revision: 938ba43a3350c4f81a5ed152b02eb92f9e68c949
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=af62dfeb5c0eeb6e5bf5a8626f2556f3fa0d7cd2&tochange=938ba43a3350c4f81a5ed152b02eb92f9e68c949

For Step4 I think the issue is not a regression, the selection changes when entering editor mode while having a large expression selcted.

Comment 4

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1624531 - Refresh codeMirror instance when input is resized. r=Honza.

This patch adds a ResizeObserver to the input node, which when triggered
refreshes the codeMirror instance.
This is needed because codeMirror draws specific elements, like the cursor
and selection blocks, and they need to be re-computed if the editor size
changed (the line might have wrapped, and the cursor need to be in a new
position now).

Depends on D78649

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8560f76ca248
Refresh codeMirror instance when input is resized. r=Honza.

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8560f76ca248

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified the issue using Firefox 79.0a1 (20200622093309) on Windows 10x64, macOS 10.12 and Ubuntu 18.04. The text is no longer selected after switching to multiline/single line editor mode.