1624549 - plainTextBody: editor.outputToString("text/plain", 0), is wrong

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Jorg K (CEST = GMT+2)]

https://searchfox.org/comm-central/rev/0c6472bec30280a0648e5101ffacaf72907e4cc2/mail/components/extensions/parent/ext-compose.js#160

This is most likely wrong, as it doesn't cater for CJK text.

You should use nsIDocumentEncoder::OutputDisallowLineBreaking

Comment 1

[Jorg K (CEST = GMT+2)]

Sorry, the line above is equally wrong:
body: editor.outputToString("text/html", 0),

Or maybe I'm wrong, maybe it doesn't matter if we don't request formatted. Best to try it with some long CJK text, like here:
https://searchfox.org/comm-central/rev/0c6472bec30280a0648e5101ffacaf72907e4cc2/mailnews/compose/test/unit/test_longLines.js#98

Comment 2

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 3

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 4

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 5

[Firefox Bug Husbandry Bot]

The severity of these bugs was changed, mistakenly, from normal to S3.

Because these bugs have a priority of --, indicating that they have not been previously triaged, these bugs should be changed to Severity of --.

Comment 6

[John Bieling (:TbSync)]

Attachment: compose.details.debug.zip

STR using the attached add-on.

1. Install this extension using the "Load Temporary Add-on ..." on the "Debug Add-ons" page.
2. Copy the following content of the attached sample.txt file into a composer (download the file to disk, do not copy its content from the html view of bugzilla).
3. Change the width of the compose window and observe how the text reflows.
4. Click on the Compose action button "Test"

-> The content of the composer will be removed and put back in after 1s.

5. Change the width of the compose window and observe how the text reflows but now has extra spaces in it.

Comment 7

[John Bieling (:TbSync)]

Attachment: sample.txt

Comment 8

[John Bieling (:TbSync)]

Attachment: compose.details.debug.zip

Comment 9

[John Bieling (:TbSync)]

Attachment: Bug 1624549 - Fix getComposeDetails for long CJK text. r=mkmelin

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d5632ba2d883
Fix getComposeDetails for long CJK text. r=mkmelin