1624585 - Fix blurry extension icons

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Serge]

Attachment: icon.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:74.0) Gecko/20100101 Firefox/74.0

Steps to reproduce:

Open app button
Observe icon of the 'Add-ons' element.
Additionally observe this favicon of the about:addons

Actual results:

The icon in Nightly (76.0a1 (2020-03-24) (64-bit)) is blurry when compared to other icons and to its counterpart in Release (74.0 (64-bit))

Expected results:

The icon should be sharp, same way as other elements on the app menu

It seems like the SVG of the icon was updated.
On Release:
File: chrome://mozapps/skin/extensions/extensionGeneric-16.svg
Dimensions: 16x16

On Nightly:
File: chrome://mozapps/skin/extensions/extension.svg
Dimensions: 64x64

Also, the majority of the UI icons are SVG with 16x16 size.

Comment 1

[Serge]

Hi, any updates on the issue?

Comment 2

[Michel Le Bihan]

I can reproduce this.

Comment 3

[Mark Striemer [:mstriemer]]

This looks fine on my Windows with 200% scaling, but if I drop that down to 100% or 150% then I see that it's blurry.

Comment 4

[Serge]

Hi,
I may be mistaken, but the issue might be caused by the fact that new icon is bigger dimension-wise when compared to default icon.
Swapping the icon back to 16x16 size should fix the issue.

Comment 5

[Tim Nguyen :ntim]

Another issue was that addon-install-confirm.svg used to have a green fill, which is consistent with other addon-install-* files, now the other one just follows the text color.

Comment 6

[Tim Nguyen :ntim]

(In reply to Tim Nguyen :ntim from comment #5)

Another issue was that addon-install-confirm.svg used to have a green fill, which is consistent with other addon-install-* files, now the other one just follows the text color.

Oh wait, the green fill was rightly removed from that usage, since the it's displayed at 16x16.

Comment 7

[Tim Nguyen :ntim]

Attachment: Bug 1624585 - Fix blurry extension icon. r=mstriemer

Comment 8

[Serge]

Hi Just noticed that a patch doesn't have
viewBox="0 0 16 16"
within SVG.
Not sure if its needed thought

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25c62e59ea89
Fix blurry extension icon. r=mstriemer

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/25c62e59ea89

Comment 11

[Maria Berlinger [:mberlinger], Services QA]

I've managed to reproduce this issue on an affected Firefox nightly from 2020-03-24 on Ubuntu 18.04x64.
This issue is verified fixed on Firefox 76.0b4 using Windows 10x64, Ubuntu 18.04x64, macOS 10.15.