1624608 - Drop down searched strings are no longer highlighted after following certain steps

Status: VERIFIED FIXED

(Firefox :: Preferences, defect, P1)

Description

[Alexandru Trif, QA [:atrif]]

Attachment: highlight_0.gif

Affected versions

• 76.0a1 (20200323092419)
• 75.0b7 (20200322132212)
• 74.0 (20200309095159)

Affected platforms

• Windows 10 x64
• Ubuntu 18.04
• macOS 10.15

Steps to reproduce

1. Open Firefox and go to about:preferences#home.
2. Click on “New tabs” dropdown and select “Blank Page”
3. Search for firefox in Find in Option.
4. Click again on “New tabs” dropdown and observe the Firefox Home string.

Expected result

• Firefox string is highlighted.

Actual result

• Firefox string is not highlighted.

Regression Range

• Last good revision: ff20472890a1e3fa12e9b24bd9ef0520faea54da
• First bad revision: 37d758a90ed9fc26c1d09993ddf73823295ea5d0
• Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ff20472890a1e3fa12e9b24bd9ef0520faea54da&tochange=37d758a90ed9fc26c1d09993ddf73823295ea5d0

Notes

• Attached a screen recording with the issue.

Comment 1

[Brian Grinstead [:bgrins]]

Looks like the highlightable class isn't getting set on the menuitem https://searchfox.org/mozilla-central/rev/8526066f548af9ec3ebb462ff73c47ccc183f533/browser/components/preferences/in-content/findInPage.js#475

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: Bug 1624608 - Fix highlightable menuitems in preferences by including them in searchWithinNode

This fixes the reported issue but I haven't yet checked to see if it causes any other problems,
or if/why this was removed in the first place.

Comment 3

[Brian Grinstead [:bgrins]]

OK, I think what's happening is that in a XBL world we hit nodeObject.childElementCount == 0 at https://searchfox.org/mozilla-central/rev/8526066f548af9ec3ebb462ff73c47ccc183f533/browser/components/preferences/in-content/findInPage.js#374. But with our current CE implementation we aren't using Shadow DOM so we do have child nodes. This was worked around for buttons when they were converted to CE in https://hg.mozilla.org/mozilla-central/rev/936c2d201405#l3.12 using the same thing my patch in Comment 2 does.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43d5a2bbdd36
Fix highlightable menuitems in preferences by including them in searchWithinNode r=jaws

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/43d5a2bbdd36

Comment 6

[Alexandru Trif, QA [:atrif]]

Verified with Firefox 76.0a1 (20200330220101) on Windows 10x64, macOS 10.12 and Ubuntu 18.04.