1624684 - ApplySkipSide can be easier to use if it returns *this

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

LogicalMargin::ApplySkipSide or BaseMargin::ApplySkipSide can be easier to use if it returns a reference to itself.

For example, this hunk

  auto bp = GetLogicalUsedBorderAndPadding(aWM);
  bp.ApplySkipSides(GetLogicalSkipSides());

can be written as (with nice const modifier)

const auto bp = GetLogicalUsedBorderAndPadding(aWM).ApplySkipSide(GetLogicalSkipSides());

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1624684 Part 1 - Remove 'const' from the return value of ComputedLogical{Margin,Borderpadding,Padding}.

There's no point to have 'const' on a newly constructed return value.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1624684 Part 2 - Let LogicalMargin::ApplySkipSides return a reference to itself, and convert some callers.

Depends on D69757

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1624684 Part 3 - Let BaseMargin::ApplySkipSides return a reference to itself, and convert some callers.

Depends on D69758

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63c5a8eb6e9c
Part 1 - Remove 'const' from the return value of ComputedLogical{Margin,Borderpadding,Padding}. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/89df1bf5dee8
Part 2 - Let LogicalMargin::ApplySkipSides return a reference to itself, and convert some callers. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/970bca14c577
Part 3 - Let BaseMargin::ApplySkipSides return a reference to itself, and convert some callers. r=jfkthame

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/63c5a8eb6e9c
https://hg.mozilla.org/mozilla-central/rev/89df1bf5dee8
https://hg.mozilla.org/mozilla-central/rev/970bca14c577