1624740 - TypeError: 'unicode' does not have the buffer interface when a mozconfig is updated

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

I've been playing around with mozconfigs, and when I updated my mozconfig file then tried mach build again, I got the following output:

~/unified$ ./mach build
 /home/matthew/unified/obj-opt-x86_64-pc-linux-gnu/config.status is out of date with respect to /home/matthew/unified/obj-opt-x86_64-pc-linux-gnu/.mozconfig.json
Error running mach:

    ['build']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: 'unicode' does not have the buffer interface

  File "/home/matthew/unified/python/mozbuild/mozbuild/build_commands.py", line 138, in build
    append_env=append_env)
  File "/home/matthew/unified/python/mozbuild/mozbuild/controller/building.py", line 1070, in build
    clobber_requested = self._clobber_configure()
  File "/home/matthew/unified/python/mozbuild/mozbuild/controller/building.py", line 1405, in _clobber_configure
    clobber_output)
  File "/home/matthew/unified/python/mozbuild/mozbuild/controller/clobber.py", line 187, in maybe_do_clobber
    print('Clobber not needed.', file=fh)

MOZCONFIG is this:

ac_add_options --enable-application=js

ac_add_options --enable-optimize
ac_add_options --disable-debug

ac_add_options --enable-smoosh
ac_add_options --enable-tests
ac_add_options --enable-binast

# Dump opt builds into another dir. 
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-opt-@CONFIG_GUESS@

I just reordered the options.

This is a local stack, built atop 01b9bdb6e5ef

Comment 1

[Ricky Stewart]

Attachment: Bug 1624740 - Use io.StringIO instead of io.BytesIO to capture text in building.py

Comment 2

[Ricky Stewart]

I can't reproduce this, but the code is obviously wrong. If you patch this revision in does it fix your problem?

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Of course, now that I try to reproduce I also cannot. I'm not sure why. It seemed to do the trick yesterday?

I'll see if it reproduces at some point again, and if it does, I'll try your patch.

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Just reproduced again this morning. No idea why. But! Good news: Applying the patch on this bug fixed it. \o/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37445084f5f8
Use io.StringIO instead of io.BytesIO to capture text in building.py r=froydnj

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/37445084f5f8