1624823 - Pass in required client_info data

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P2)

Description

[Jan-Erik Rediger [:janerik]]

Follow up once we have client_info support:

Glean has a small set of always-available data, see client_info docs

We can detect at build time:

• os - operating system
• app_build - I think the build id is available?
• app_channel - I think we want the actual build's channel, so it should be available?

We need to pass in at runtime:

• architecture - I guess a 32bit build could run on 64bit, so we want to detect that at runtime
• device_manufacturer - definitely runtime, but do we want it?
• os_version
• locale

Comment 1

[Alessio Placitelli [:Dexter]]

(In reply to Jan-Erik Rediger [:janerik] from comment #0)

We need to pass in at runtime:

• architecture - I guess a 32bit build could run on 64bit, so we want to detect that at runtime

Yes, but keep in mind that this is the device architecture

• device_manufacturer - definitely runtime, but do we want it?

This can be made optional in the schema/SDK side. This was mostly geared towards mobile, altough Mike did some great work in Python to detect that.

Comment 2

[Jan-Erik Rediger [:janerik]]

architecture - so definitely at runtime then

device_manufacturer - Right now we have nothing directly comparable in the Telemetry environment. We have appleModelId (obviously mac-only). Question is: do we want to have something like that? Who do I involve to tell us if/what would make sense?

Comment 3

[Chris H-C :chutten]

(In reply to Jan-Erik Rediger [:janerik] from comment #2)

architecture - so definitely at runtime then

Yup. Leave it for someone else to express the need for the build's arch and detecting eg WoW64.

device_manufacturer - Right now we have nothing directly comparable in the Telemetry environment. We have appleModelId (obviously mac-only). Question is: do we want to have something like that? Who do I involve to tell us if/what would make sense?

Answer: No, we don't. In my opinion what to do with the Environment is a decision to be made at Migration time by people invested in owning those data collections. We're not at Migration time and we're not interested in owning the collections, so we shouldn't do this.

Again, all in my opinion.

Comment 4

[Jan-Erik Rediger [:janerik]]

(In reply to Chris H-C :chutten from comment #3)

Answer: No, we don't.

I agree with this, it will require us to change the schema though to make that field optional if we want to start sending out valid minimal pings.

Comment 5

[Jan-Erik Rediger [:janerik]]

By mistake the patch set for this bug was also attached to bug 1626621. It's currently on autoland, so I'll manually close this bug here when the code lands.

Comment 6

[Jan-Erik Rediger [:janerik]]

Oh, actually we're still missing locale. I'm splitting that out.