1624830 - ./mach bootstrap should use the release branch of cinnabar

Status: RESOLVED WORKSFORME

(Firefox Build System :: Bootstrap Configuration, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

When ./mach bootstrap installs git-cinnabar, it checks out the latest master branch of cinnabar. But then if there are commits to cinnabar upstream, every use of cinnabar will emit a warning about the master branch being out of date. It would be better if bootstrap checked out cinnabar to the release branch instead to avoid these warnings, and to also get a presumably more-reliable cinnabar version.

Comment 1

[Ricky Stewart]

Glandium, any thoughts about this?

Comment 2

[Mike Hommey [:glandium]]

every use of cinnabar will emit a warning about the master branch being out of date.

That shouldn't be the case. It should happen at most once a day.

Comment 3

[Mike Hommey [:glandium]]

If it happens more than once a day, I can think of a corner case that would trigger that. What's the output for git config -l --show-origin | grep cinnabar, when you run it from a repo when it happens more frequently than once a day?

Comment 4

[Kartikaya Gupta (email:[e-mail])]

(In reply to Mike Hommey [:glandium] from comment #2)

every use of cinnabar will emit a warning about the master branch being out of date.

That shouldn't be the case. It should happen at most once a day.

Ah, that might be true. I just noticed the warnings a bunch of times without paying attention to exactly how often it happened. I guess I assumed it would happen every time. I tried just now running a few basic operations and it didn't warn me.

I ran the command you requested and got this:

file:/home/kats/.gitconfig	cinnabar.helper=/Users/kats/.mozbuild/git-cinnabar/git-cinnabar-helper
file:/home/kats/.gitconfig	cinnabar.version-check=1585227593
file:/home/kats/zspace/gecko/.git/config	cinnabar.fsck=1584560848

Comment 5

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Comment 6

[Mike Hommey [:glandium]]

As of bug 1787993, bootstrap installs the last release.