1624857 - AttributeError: 'timeout' object has no attribute 'with_traceback'

Status: RESOLVED FIXED

(Testing :: Mochitest, defect, P3)

Description

[Geoff Brown [:gbrown]]

In bug 1414495 and bug 1615608, some logs show this message following timeout failures.

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=294621082&repo=mozilla-central&lineNumber=7007
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=294265661&repo=autoland&lineNumber=1827

Indeed with_traceback is used in runtests.py:
https://searchfox.org/mozilla-central/rev/c80fa7258c935223fe319c5345b58eae85d4c6ae/testing/mochitest/runtests.py#2388
and runtests.py is run in python 2 in CI.

The consequence is that important diagnostic information is lost.

Comment 1

[Geoff Brown [:gbrown]]

Should runtests.py / runtestsremote.py be run only with Py3? Or should those scripts be compatible with Py2 and Py3?

Comment 2

[Geoff Brown [:gbrown]]

I suppose a Py3 venv for mozharness is needed in order to run a test harness in python 3. There is support for that at

https://searchfox.org/mozilla-central/rev/4d9cd186767978a99dafe77eb536a9525980e118/testing/mozharness/mozharness/base/python.py#746

but that's only currently used by Talos (!). And it seems to be conveniently applicable only to an entire mozharness script, not a subset of test suites.

So I think runtests.py / runtestsremote.py need to remain Py2 compatible for the time being.

Comment 3

[Geoff Brown [:gbrown]]

See also https://searchfox.org/mozilla-central/rev/4d9cd186767978a99dafe77eb536a9525980e118/layout/tools/reftest/runreftest.py#92 (looks good: py2/py3 compat).

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:ahal, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Andrew Halberstadt [:ahal]]

Definitely looks like a bug, mochitest doesn't support Python 3 yet.. Seems worth fixing in the meantime.

Comment 6

[Intermittent Failures Robot]

1 failures in 5582 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• linux1804-64-tsan: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1624857&startday=2020-04-20&endday=2020-04-26&tree=all

Comment 7

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Comment 8

[Geoff Brown [:gbrown]]

Attachment: Bug 1624857 - Resolve intermittent mochitest AttributeError on with_traceback; r=

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfdcb6fd0572
Resolve intermittent mochitest AttributeError on with_traceback; r=bc

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/cfdcb6fd0572