Closed Bug 1624865 Opened 5 months ago Closed 5 months ago

Scope wizard styles to wizard custom element

Categories

(Toolkit :: Themes, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The wizard.css styles are fairly self-contained and <wizard> is already using shadow DOM, so doing this should be fairly easy.

Priority: -- → P1
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e14ac21fde64
Scope wizard.css to wizard custom element. r=dao
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29024ee1f5a7
Backed out changeset e14ac21fde64 for perma bc failures in "chrome://browser/content/migration/migration.js CLOSED TREE
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/753c5e83ea11
Scope wizard.css to wizard custom element. r=dao
Flags: needinfo?(ntim.bugs)

Hey Matt, do you know why this patch might be breaking the migration wizard ? Even without the migrator related changes in this patch, the failure happens (see comment 3).

Flags: needinfo?(ntim.bugs) → needinfo?(MattN+bmo)

I don't know why this patch would cause it but I can fix the root issue in the test. The issue seems to be that uninit is getting called before init because the test isn't waiting for the wizard to be loaded. I considered fixing migration.js to not uninit if it didn't init but that's more complicated and isn't something that users will ever care about.

I'll re-land your patch on top of mine.

Flags: needinfo?(MattN+bmo)
Depends on: 1594440
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/ea13cc098fe9
Scope wizard.css to wizard custom element. r=dao
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76

(In reply to Matthew N. [:MattN] (PM me if request are blocking you) from comment #8)

I don't know why this patch would cause it but I can fix the root issue in the test. The issue seems to be that uninit is getting called before init because the test isn't waiting for the wizard to be loaded. I considered fixing migration.js to not uninit if it didn't init but that's more complicated and isn't something that users will ever care about.

I'll re-land your patch on top of mine.

Thanks Matt!

Blocks: 1618051
You need to log in before you can comment on or make changes to this bug.