1624865 - Scope wizard styles to wizard custom element

Status: RESOLVED FIXED

(Toolkit :: Themes, task, P1)

Description

[Tim Nguyen :ntim]

The wizard.css styles are fairly self-contained and <wizard> is already using shadow DOM, so doing this should be fairly easy.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1624865 - Scope wizard.css to wizard custom element.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e14ac21fde64
Scope wizard.css to wizard custom element. r=dao

Comment 3

[Stefan Hindli [:stefan_hindli]]

Backed out changeset e14ac21fde64 (Bug 1624865) for perma bc failures in "chrome://browser/content/migration/migration.js CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=58c3533fd95a962487b976a4a129dc6e67f7596a&selectedJob=294878320

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=294878320&repo=autoland&lineNumber=37060

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29024ee1f5a7
Backed out changeset e14ac21fde64 for perma bc failures in "chrome://browser/content/migration/migration.js CLOSED TREE

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/753c5e83ea11
Scope wizard.css to wizard custom element. r=dao

Comment 6

[Arthur Iakab [arthur_iakab]]

Backed out changeset 753c5e83ea11 (bug 1624865) for causing browser chrome failures and turning Bug 1594440 into perma.

Backout revision https://hg.mozilla.org/integration/autoland/rev/2d758b42bd735b4892c64bd54823bd9412c925d2

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C10%2Cx64%2Cquantumrender%2Cdebug%2Cmochitests%2Ctest-windows10-64-qr%2Fdebug-mochitest-browser-chrome-e10s-1%2Cm%28bc1%29&revision=753c5e83ea11ca696f43fc9626defa61c6b6e534

Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=294942525&repo=autoland

Tim can you please take a look?

Comment 7

[Tim Nguyen :ntim]

Hey Matt, do you know why this patch might be breaking the migration wizard ? Even without the migrator related changes in this patch, the failure happens (see comment 3).

Comment 8

[Matthew N. [:MattN]]

I don't know why this patch would cause it but I can fix the root issue in the test. The issue seems to be that uninit is getting called before init because the test isn't waiting for the wizard to be loaded. I considered fixing migration.js to not uninit if it didn't init but that's more complicated and isn't something that users will ever care about.

I'll re-land your patch on top of mine.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea13cc098fe9
Scope wizard.css to wizard custom element. r=dao

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ea13cc098fe9

Comment 11

[Tim Nguyen :ntim]

(In reply to Matthew N. [:MattN] (PM me if request are blocking you) from comment #8)

I don't know why this patch would cause it but I can fix the root issue in the test. The issue seems to be that uninit is getting called before init because the test isn't waiting for the wizard to be loaded. I considered fixing migration.js to not uninit if it didn't init but that's more complicated and isn't something that users will ever care about.

I'll re-land your patch on top of mine.

Thanks Matt!